Just updating <https://github.com/joreilly/MortyComposeKMM> to Apollo 3.4.0 and getting following er...

# apollo-kotlin

[John O'Reilly]

Just updating https://github.com/joreilly/MortyComposeKMM to Apollo 3.4.0 and getting following error

extra.graphqls: (36, 30): Unknown argument `field` on directive 'nonnull'

The section it's referring to is as follows....was there change made related to this?

extend type Episode @nonnull(field: """
id
name
air_date
episode
characters
created
""")

[John O'Reilly]

The previous version this was on was 3.3.0 so could be related to change between that and 3.4.0

[mbonnin]

There were definitely changes around this. We used to not validate directives at all and introduced some validation as part of 3.3.1 IIRC

[mbonnin]

Let me check MortyComposeKMM

[mbonnin]

You'll need to use fields instead of field

[mbonnin]

The directive definition is there

[mbonnin]

extend type Episode @nonnull(fields: """
id
name
air_date
episode
characters
created
""")

[John O'Reilly]

ah, nice, thanks....that works now

[John O'Reilly]

looks like other ones had fields but had typo in this one

[mbonnin]

More details at https://github.com/apollographql/apollo-kotlin/pull/4174

[mbonnin]

TLDR: as we add more directives, we'll need to add more validation and also allow renaming them in case of name clash with existing directives