in kmm why can’t we use apollo library under IOS 13 ?

There was something about WebSockets IIRC

What exactly is the purpose of the NSURLSessionWebSocketTask? is that for graphql subscriptions ?

yes, exactly subscriptions

Maybe a version without subscriptions could be released in order to serve users under iOS 13. not sure if that would be hard

Do you get an error when trying to build your iOS app?

Sorry for the late response, when i run the app with iphone 5 ( ios 12.4 ) i'm getting this crash

dyld: Symbol not found: _OBJC_CLASS_$_NSURLSessionWebSocketMessage
 Referenced from: /Users/alkincakiralar/Library/Developer/Xcode/DerivedData/fizbot-alhlyiyitptqumeebpzkemzcvngh/Build/Products/Debug-iphonesimulator/Bifrost.framework/Bifrost
 Expected in: /Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/Foundation.framework/Foundation
 in /Users/alkincakiralar/Library/Developer/Xcode/DerivedData/fizbot-alhlyiyitptqumeebpzkemzcvngh/Build/Products/Debug-iphonesimulator/Bifrost.framework/Bifrost
dyld: launch, loading dependent libraries
DYLD_FRAMEWORK_PATH=/Users/alkincakiralar/Library/Developer/Xcode/DerivedData/fizbot-alhlyiyitptqumeebpzkemzcvngh/Build/Products/Debug-iphonesimulator:/Users/alkincakiralar/Library/Developer/Xcode/DerivedData/fizbot-alhlyiyitptqumeebpzkemzcvngh/Build/Products/Debug-iphonesimulator/PackageFrameworks
DYLD_FALLBACK_LIBRARY_PATH=/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot/usr/lib
DYLD_ROOT_PATH=/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot
DYLD_FALLBACK_FRAMEWORK_PATH=/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks
DYLD_INSERT_LIBRARIES=/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot/usr/lib/libBacktraceRecording.dylib:/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 12.4.simruntime/Contents/Resources/RuntimeRoot/usr/lib/
(lldb)

Alright 👍

yes at start time, also i just implement the library with spm and didn't import any viewcontroller or classes

I see. Mind opening an issue about this?

You want me to open an issue about it ?

Yes please. Doesn't look easy to workaround unfortunately 😞

i see, im gonna open an issue thanks for your help 👍

For the record, I just bumped into the previous issue that was mentioning this

Should i open the ticket as bug report or feature request ?

"it depends" 🙂

https://github.com/apollographql/apollo-kotlin/issues/4276 I opened the issue

Thanks for reporting this 💙

Seeing this same issue. Do you happen to have a path for the websockets stuff on 3.x? The link in the original issue appears to be broken.

@Paddy O'Brien do you need websockets on iOS < 13 or do you just need the regular queries to work on iOS < 13?

Nah we just need regular queries to work, Shopify doesn’t use subscriptions. Was just looking for the path where the socket stuff has moved to as it seems to have changed between 2.x and 3.x.

Gotcha 👍. It's 100% doable. We have the

NetworkTransport

API as well as a lower level

WebSocketEngine

one. The trick here is to do it in a backward compatible way. That certainly means splitting the current

apollo-runtime

that has a hard dependency on iOS13+ at the moment and introducing separate artifacts, one of those without the iOS13+ dependency

They do, the location of the code just changed. The link in the initial issue you found with Ellen and Ivan seems to be broken. I think I found it though. building now 😄

What link?

The one mentioned here https://kotlinlang.slack.com/archives/C01A6KM1SBZ/p1658151856484459?thread_ts=1657920672.252619&amp;cid=C01A6KM1SBZ

That one? https://github.com/apollographql/apollo-kotlin/blob/main/apollo-runtime-kotlin/src[…]n/kotlin/com/apollographql/apollo/network/ws/ApolloWebSocket.kt

yeah https://github.com/apollographql/apollo-android/blob/main/apollo-runtime-kotlin/sr[…]n/kotlin/com/apollographql/apollo/network/ws/ApolloWebSocket.kt

Gotcha

I get a 404

Yea, it's using

main

looks like everything is now in NSURLWebsocketEngine.kt

If you remove everything in that file with

TODO("make this work with iOS < 13")

, you should be able to link and run everything

Everything? I tried to leave it as an empty type but im getting errors

Something like this should do the job:

actual class DefaultWebSocketEngine : WebSocketEngine {
  override suspend fun open(url: String, headers: List<HttpHeader>): WebSocketConnection {
    TODO("Not yet implemented")
  }

  override suspend fun open(url: String, headers: Map<String, String>): WebSocketConnection {
    TODO("Not yet implemented")
  }

}

Seems to have done the trick, Thanks

Sure thing!