:rocket: <v0.34.1 released!> FTR: v.34.0 contains...

# github-workflows-kt

[Piotr Krzemiński]

🚀 v0.34.1 released!

FTR: v.34.0 contains a bug that makes it unusable (Java bytecode mismatch showing up in YAML consistency jobs), 0.34.1 fixes it by installing a proper Java version first

[LeoColman]

Found a small breaking change

[LeoColman]

The signature SetupJavaV3 changed the order of the parameters

[LeoColman]

The quickest fix is to just add the parameter name.
https://github.com/LeoColman/Petals/commit/f7ebc9f0c38549c00ea398a36958ccc589826d93

[Piotr Krzemiński]

right, a new parameter was added, see this commit. The order of arguments is the same as in action’s action.yml, so it’s definitely recommended to use named parameters when calling the actions

[Piotr Krzemiński]

do you think it would help if we mentioned it in the docs, e.g. here? https://krzema12.github.io/github-workflows-kt/user-guide/using-actions/

[LeoColman]

I think adding it to the breaking chanves of 0.34.1 is quite enough for now.
If that happens again after 1.0.0 maybe we should add more info on it

[Piotr Krzemiński]

hmm, so far I haven’t really paid attention if a change in actions leads to breaking existing usage, just communicated it for the library’s API. For actions, I usually just write that the wrapper got updated. I’ll think how to improve here in a scalable manner, ultimately I want to automate these updates to the max so the automation would theoretically have to infer if it was a breaking change

[Piotr Krzemiński]

for now I’ll just go with a simple note in the release notes: https://github.com/krzema12/github-workflows-kt/releases/tag/v0.34.0

[Piotr Krzemiński]

@LeoColman you may be interested in https://kotlinlang.slack.com/archives/C0B8MA7FA/p1676985449906609 - I’m tentatively planning to enforce named arguments when using actions, it would definitely add to the safety: https://github.com/krzema12/github-workflows-kt/issues/693