https://kotlinlang.org logo
#eap
Title
# eap
z

Zac Sweers

01/10/2023, 6:22 AM
Did something change between RC2 and release in the kotlin-bom around tests? RC2 was passing for us on CI, but with the final release I see some esoteric gradle conflicts around the kotlin test libraries. Lmk if I should file a bug
👀 1
i

Ivan Kubyshkin [JetBrains]

01/10/2023, 8:47 AM
cc @tapchicoma
t

tapchicoma

01/10/2023, 10:39 AM
RC2 release should be the similar to final release. And I don't see any changes in bom file. Please open an issue with repro
z

Zac Sweers

01/10/2023, 1:47 PM
Will see if I can get a public repro going
Were any of these artifacts folded due to JDK 8 like the stdlib artifacts were?
t

tapchicoma

01/10/2023, 1:48 PM
afaik no
z

Zac Sweers

01/10/2023, 1:48 PM
Hmmm strange. I’ll keep digging
t

tapchicoma

01/11/2023, 8:50 AM
I've checked
.modules
files content between the releases and only difference between them is capabilities order 🤔
z

Zac Sweers

01/11/2023, 7:08 PM
super weird, when I output dependencies on CI, I see junit5 coming in from kotlin-test
Copy code
|    +--- project :libraries:foundation:test-commons
|    |    +--- org.ow2.asm:asm-bom:9.4 (*)
|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*)
|    |    +--- com.google.firebase:firebase-bom:31.1.1 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-bom:1.8.0 (*)
|    |    +--- com.squareup.okhttp3:okhttp-bom:5.0.0-alpha.10 (*)
|    |    +--- com.squareup.okio:okio-bom:3.3.0 (*)
|    |    +--- com.squareup.wire:wire-bom:4.4.3 (*)
|    |    +--- project :tooling:slack-platform (*)
|    |    +--- junit:junit:4.13.2 (*)
|    |    +--- org.jetbrains.kotlin:kotlin-test:1.8.0
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 (*)
|    |    |    \--- org.jetbrains.kotlin:kotlin-test-junit5:1.8.0 FAILED
I’m entirely unable to reproduce this locally though
so somehow on CI,
junit5RuntimeVariant
is being selected as the capability
I wonder if there’s a gradle plugin sneakily turning on
useJUnitPlatform()
in test tasks
bonus bit to close this out - the reason I didn’t hit this on CI previously was because I was doing most of my initial testing prior to this on github actions, and our final “main” CI is on buildkite. Hence why I didn’t see it before. Will include that in testing future EAPs 😅
4 Views