Hi Arnaud there are two bugs in the koin android compat libr kotlinlang #koin-contributors

Hi Arnaud, there are two bugs in the koin-android-...

Christian Krueger

01/10/2023, 12:54 PM

Hi Arnaud, there are two bugs in the koin-android-compat library. 1.

SharedViewModelCompat

passed the wrong ViewModelStore (see bug issue) 2. The

ViewModelCompatgetViewModel

always sets

extras = CreationExtras.Empty

, which causes a missing

SAVED_STATE_REGISTRY_OWNER_KEY

I can fix both issues + writing some unit tests.

arnaud.giuliani

01/13/2023, 10:52 AM

if you can propose a PR, it’s great 👍

12 Views