Was the feature to add JvmOverloads to copy method was alrea kotlinlang #random

Was the feature to add @JvmOverloads to copy method was already asked? I am having issues with data class compatibility: https://github.com/jasync-sql/jasync-sql/issues/359

ephemient

01/17/2023, 8:28 AM

data classes are challenging to evolve with API/ABI compatibility. the constructor also changes, as do

componentN()

destructuring

https://jakewharton.com/public-api-challenges-in-kotlin/

oshai

01/17/2023, 8:35 AM

yes... but constructor have jvm overloads and I only add new fields. I think only the copy is an issue in such case

Found this: https://stackoverflow.com/questions/52410264/is-it-possible-to-add-jvmoverloads-to-the-generated-copy-method-in-kotlin

and this: https://discuss.kotlinlang.org/t/jvmoverloads-for-data-classes/13659

but maybe I should open a new request for it?

I created a youtrack issue, you're welcome to vote: https://youtrack.jetbrains.com/issue/KT-56022/Support-JvmOverload-for-data-class-copy-function

ephemient

01/21/2023, 9:56 PM

@JvmOverloads

only addresses Java compatibility. Kotlin calls don't use the generated overloads so any change to the data class is binary incompatible for Kotlin (unless you write the overloads manually), whether you have

@JvmOverloads

or not.

oshai

01/22/2023, 6:06 AM

For my original issue I change it to non data class and wrote the copy myself.

ephemient

01/22/2023, 8:36 AM

my point is that

@JvmOverloads constructor()

and

@JvmOverloads fun copy()

still break binary compatibility for Kotlin callers when arguments are added, regardless of

data class

or not

oshai

01/22/2023, 3:27 PM

that's unfortunate

#random Join Slack