Why does the consistency check job use `actions/se...

# github-workflows-kt

[Vampire]

Why does the consistency check job use actions/setup-java and with cache: gradle?
The consistency check job just calls the Kotlin file and calls git afterwards.
I don't see where it might need Java or Gradle.

[Piotr Krzemiński]

Regarding actions/setup-java , I want to use newest-ish JRE (LTS, to not make changes in consistency jobs too often), otherwise the default Java 11 is used (related bug and fix after this change). Java itself is still needed as runtime for Kotlin scripts.

About Gradle caching, it’s probably a copy-paste error - you’re right it seems not needed. Not sure how much it influences the running time, but I’ll remove it for the sake of simplicity.

[Vampire]

Ah, right, oh course.
Yeah, I also had to change the toolchain for the JavaExec Gradle task to 17 after you requiring it.

I don't really understand why you do as long as you don't use some 17+ lib, though. Kotlin is Kotlin is Kotlin. The bytecode version shouldn't matter much for the lib, should it? The probably only effect would be, that you force consumers to use 17+ while there is absolutely no need to, while at the same time making the consistency check a bit slower due to the need for installing Java 17.

May I ask what the reason was for that change?
Don't get me wrong, I second that move for any end project. I just don't like it for libs without reason and especially for one where the default in its typical usage scenario is 11. :-)

[Piotr Krzemiński]

hmm, maybe you’re right - it’s enough to use some new JDK and keep the bytecode version so that JRE 11 can understand it. You convinced me, I’ll revert these changes: 1 and 2 🙂

[Piotr Krzemiński]

thanks for bringing it up!
here’s a tracking ticket: https://github.com/krzema12/github-workflows-kt/issues/637
merged: https://github.com/krzema12/github-workflows-kt/commit/3916a15ab6e7910c2b4663585c1a9491ba797819

[Vampire]

Even Java 8 should be enough, I think there the indy for lambdas was introduced. But let's not exaggerate 😄

[Piotr Krzemiński]

Java setup step was removed from the consistency check job, I think we can assume it’s good enough 🙂

[Vampire]

When do you intend to release that change?
Just curious.

[Piotr Krzemiński]

as it’s not critical, it will go into the nearest scheduled bi-weekly release, that is February 3rd

[Vampire]

The cache: gradle even complained actually. 🙂