Today I wrote this code: ```if (iterator.hasNext()) doSomethingWith(iterator.next()) ?: return null ...

# random

[Sam]

Today I wrote this code:

if (iterator.hasNext()) doSomethingWith(iterator.next()) ?: return null else return null

I have very mixed feelings about return null else return null 😄

[ephemient]

you could do

(if (iterator.hasNext()) doSomethingWith(iterator.next()) else null) ?: return null

or if it's an iterator of non-null,

iterator.takeIf { it.hasNext() }?.let { doSomethingWith(it.next()) } ?: return null

[ephemient]

I've thought Iterator<T>.nextOrNull() could be useful on a handful of occasions, but not very often

[Sam]

takeIf { it.hasNext() } is a nice idea, I'll have to have a play with that 👌

[janvladimirmostert]

https://twitter.com/polyglotamus/status/1584481825279594496

I recently saw this snippet

[ephemient]

`?: throw`/`checkNotNull`/`requireNotNull` can be better than !! in some situations, such as when providing a detailed message, because Kotlin doesn't. https://youtrack.jetbrains.com/issue/KT-6989
but that doesn't apply to that code snippet 😞

[Sam]

And maps have getValue too, but I'd have to check how useful its message is. I've never been quite sure whether it's actually intended to be used at all on non-defaulted maps...

[ephemient]

getValue throws NoSuchElementException("Key $key is missing in the map."), so it is useful