You can use the immediate recomposer on every platform and i kotlinlang #squarelibraries

You can use the immediate recomposer on every plat...

01/28/2023, 2:51 AM

You can use the immediate recomposer on every platform, and it is available to common code. On iOS/tvOS/macOS we are adding a FrameClock powered by the DisplayLink here: https://github.com/cashapp/molecule/pull/170. It's blocked on me figuring out how the hell to unit test it. I think we have a JS frame clock somewhere that uses animation callbacks to determine frames. We can probably steal the Desktop Compose UI one to get an AWT FrameClock for desktop JVM. The problem with those latter three is that you still have to set them up inside your coroutine context on each platform individually because they're all platform specific. Once you have that context, though, you can move back into fully-common code for the actual composable functions.

👍 3

kevin.cianfarini

01/28/2023, 2:55 AM

Jake would it be considered poor form to try and track down someone from jetbrains who knows about iOS simulator unit tests and ask them directly? My post in #kotlin-native got no traction. Otherwise I could consider asking in #multiplatform

01/28/2023, 2:55 AM

I am making steady progress

01/28/2023, 2:56 AM

Hopefully Monday or Tuesday I can figure out the final thing and get it merged.

kevin.cianfarini

01/28/2023, 2:56 AM

I'll be interested to see the end result. Thanks for bringing this over the finish line

01/28/2023, 2:56 AM

We can always fall back to a full xcode project that depends on the library, but it'd be nice to avoid!

kevin.cianfarini

01/28/2023, 2:57 AM

Yeah agreed.

xxfast

01/28/2023, 2:58 AM

thanks 👍 So for now we are stuck with

Immediate

, but in the future we can use the

ContextClock

together with some form of

app.cash.molecule.AwtUiDispatcher

and whatever apple one end up being called?

01/28/2023, 2:58 AM

what platforms are you running on?

xxfast

01/28/2023, 2:59 AM

desktop, ios and js

kevin.cianfarini

01/28/2023, 3:00 AM

Redwood has the js frame clock if you want to copypasta that

01/28/2023, 3:01 AM

That one is time based because we're running it in a headless JS engine

kevin.cianfarini

01/28/2023, 3:01 AM

Oof lol nvm

01/28/2023, 3:01 AM

At one point we had a UI-based one

01/28/2023, 3:02 AM

https://github.com/cashapp/redwood/blob/trunk/redwood-compose/src/jsMain/kotlin/app/cash/redwood/compose/WindowAnimationFrameClock.kt

01/28/2023, 3:03 AM

Jesse moved the time-based one from JS to run on the host

01/28/2023, 3:05 AM

I'll make sure we get this and an AWT one for desktop in Molecule along with the darwin ones in the above PR.

🙂 1

kevin.cianfarini

01/28/2023, 3:08 AM

I can do some research on what potential frame callbacks exist on linux.

01/28/2023, 3:11 AM

i would expect Windows to have one. I wouldn't expect Linux to have anything and us having to provide options for Wayland and X11, if we should even bother.

01/28/2023, 3:11 AM

i'm in no hurry if no one wants them

jessewilson

01/28/2023, 3:47 AM

I’ve got the bridges to integrate a proper one in Redwood

jessewilson

01/28/2023, 3:49 AM

This one is temporary! https://github.com/cashapp/redwood/blob/trunk/redwood-treehouse/src/hostMain/kotlin/app/cash/redwood/treehouse/ZiplineSession.kt#L37

efemoney

08/14/2024, 2:46 PM

Did we ever get to add the JVM frame clock? I dont see one anywhere 👀

jessewilson

08/14/2024, 8:50 PM

Nope

jessewilson

08/14/2024, 8:50 PM

No Swing or AWT

efemoney

08/14/2024, 8:52 PM

Okay thanks! I thought I was bugging. Wanted to do

Copy code

expect val MoleculeContext: CoroutineContext

but I’ll stick with

Immediate

for now

08/14/2024, 9:26 PM

Feel free to PR a time based one in common

👍🏾 1

17 Views

Open in Slack

Previous Next