when doing `KSType` comparison, should we always c...

# ksp

[Yang]

when doing KSType comparison, should we always check for nullability explicitly?

val someType: KSType = 
if (someType == resolver.builtIns.stringType || someType == resolver.builtIns.stringType.makeNullable()) {
  ...
}

[Jiaxiang]

nullable types and non nullable types are different, they do have a subtyping relation, but if your use case is around strict equality check, then nullability has to be checked.

[Yang]

Thanks! Is it enough to check someType.declaration == otherType.declaration if I don’t care about the nullability difference?

[Jiaxiang]

no, you still need to consider type arguments.

[Yang]

How about someType.makeNullable() == otherType.makeNullable()?

[Jiaxiang]

that should work.

[Yang]

If I’m comparing against a builtin type I don’t need to consider type argument right?

[Jiaxiang]

there are still generic types in builtins, it’s really up to your use case.

[Yang]

Ok thank you!