jlleitschuh
02/08/2023, 1:57 PMSha Sha Chu
02/08/2023, 3:34 PMEmil Kantis
02/08/2023, 3:49 PMPaul Dingemans
02/08/2023, 4:31 PMSha Sha Chu
02/08/2023, 4:32 PMwakingrufus
02/08/2023, 8:55 PMPaul Dingemans
02/08/2023, 9:02 PMwakingrufus
02/09/2023, 3:12 PMPaul Dingemans
02/15/2023, 8:39 PM0.49.x
. See https://github.com/pinterest/ktlint/blob/master/CHANGELOG.md for a description of the breaking changes.
See https://pinterest.github.io/ktlint/install/snapshot-build/ for the snapshot build containing the changes. I am not planning any other breaking changes in this release, unless I encounter obvious mistakes. This would be really a good moment to verify the impact of the changes in 0.49.x
as we can the release within certain limits if that is convenient. Let me know, what I can do to help you in this process.
In https://github.com/pinterest/ktlint/milestone/21 you can monitor what other changes I am planning to implement before the next version will be released. I expect this to take between 3 to 8 weeks throughput time.wakingrufus
02/15/2023, 9:51 PM0.48.2 - 2023-01-21
was all part of 0.48.0 already right?Paul Dingemans
02/18/2023, 11:23 AM0.48.2
or older.## [0.48.2] - Unreleased
should be taken into account. So in the the markdown file it is line 1 to 228 that describe the breaking changes. Sorry for the inconvenience. I will fix this tomorrow.wakingrufus
02/20/2023, 5:01 PM.editorconfig
? I'd like to avoid parsing the file myself in order pass it in as a EditorConfigDefaults if possible, as it seems like that is not what that param is meant to be used forPaul Dingemans
02/20/2023, 8:48 PMEditorConfigDefaults
that does this for you since a couple of releases.wakingrufus
02/20/2023, 9:39 PMPaul Dingemans
02/21/2023, 11:25 AM0.47.0
it was possible to specify the path to .editorconfig
in the ExperimentalParameters
. The usage of that parameter was however unclear and let to usages in which different API consumers had different expectations about that parameter. So it has been deprecated in 0.47.0
and removed in 0.48.0
. Re-introducing the parameter in the KtlintRuleEngine
would re-introduce the old problem so that does not seem the way forward.
I don’t know how the plugin usually supports backward compatibility. Can the reflection problem be avoided by exposing some other functionality in a separate module to bridge the gap? This module could for example be maintained until Ktlint 1.0 is release which really seems to be a good to drop the backward compatibility guarantee of he plugin.wakingrufus
02/21/2023, 4:36 PMPaul Dingemans
02/25/2023, 11:10 AM0.49
and rebrand it to 1.0
if we would agree on this. How would you feel about that?wakingrufus
02/25/2023, 4:10 PMPaul Dingemans
02/25/2023, 4:19 PM0.49
. Instead we would basically copy a stripped version of the current plugin into the ktlint project without any of the code that is needed to maintain backwards compatibility with older ktlint versions which would not make sense when they are combined in one project. The current plugin project can then become obsolete and frozen at 0.48
.wakingrufus
02/25/2023, 4:22 PMPaul Dingemans
02/25/2023, 4:28 PMjlleitschuh
02/25/2023, 4:29 PMPaul Dingemans
02/25/2023, 4:31 PMwakingrufus
02/25/2023, 4:31 PMPaul Dingemans
02/25/2023, 4:32 PMwakingrufus
02/25/2023, 4:36 PMEmil Kantis
02/25/2023, 4:49 PMPaul Dingemans
02/25/2023, 4:50 PMwakingrufus
02/25/2023, 4:50 PMPaul Dingemans
02/25/2023, 4:57 PM1.0
. Another hurdle is the availability of maintainers. I think it would be great if we can combine forces into a single repository with multiple active maintainers. The number of active maintainers in Ktlint is approximately 1 …Sha Sha Chu
02/25/2023, 5:10 PMwakingrufus
02/25/2023, 6:05 PMPaul Dingemans
02/25/2023, 6:50 PM1.0
version of the API. Lets keep in touch.wakingrufus
02/25/2023, 6:58 PMPaul Dingemans
03/24/2023, 5:01 PM0.49.x
. Only one issue is left to implement and then regression testing starts. If you would like me to make adjustments to the API of the next release, you should do so asap. I expect to release the next version by the end of next week otherwise.
The 0.49.x
release can be seen as a release candidate for the 1.0.x
version. The API for the 1.0.x
should be identical to the 0.49.x
with exception of removal of API’s which will be deprecated in 0.49.x
.