Hi everyone, does anyone experiencing recomposition issue when using extension scope? If the compos...

# compose

[Djaka Pradana Jaya Priambudi]

Hi everyone, does anyone experiencing recomposition issue when using extension scope?

If the composable had scope like this

fun RowScope.Item() {}

The recomposition doesn't triggered (tested by adding a breakpoint and console log)

But if I remove the extension to this

fun Item() {}

It works

Sample code in thread

[Djaka Pradana Jaya Priambudi]

Works

@Composable
internal fun Test(compose: @Composable () -> Unit, xml: @Composable () -> Unit) {
    var isFirstItemSelected by remember { mutableStateOf(true) }

    Column {
        Row(Modifier.fillMaxWidth()) {
            Item(
                isSelected = isFirstItemSelected,
            ) { isFirstItemSelected = true }
            Item(
                isSelected = !isFirstItemSelected
            ) { isFirstItemSelected = false }
        }
    }
}

@Composable
fun Item(
    isSelected: Boolean = false,
    modifier: Modifier = Modifier,
    onClick: () -> Unit
) {
    Surface(
        modifier
            .selectable(
                selected = isSelected,
                onClick = onClick
            )
            .defaultMinSize(minWidth = 48.dp, minHeight = 48.dp)
    ) {
        Column {
            Text("Item", color = if (isSelected) MaterialTheme.colorScheme.primary else MaterialTheme.colorScheme.onBackground)
        }
    }
}

Screen Recording 2023-02-10 at 01.36.37.mov

[Djaka Pradana Jaya Priambudi]

Broken

@Composable
internal fun Test(compose: @Composable () -> Unit, xml: @Composable () -> Unit) {
    var isFirstItemSelected by remember { mutableStateOf(true) }

    Column {
        Row(Modifier.fillMaxWidth()) {
            Item(
                isSelected = isFirstItemSelected,
            ) { isFirstItemSelected = true }
            Item(
                isSelected = !isFirstItemSelected
            ) { isFirstItemSelected = false }
        }
    }
}

@Composable
fun RowScope,Item(
    isSelected: Boolean = false,
    modifier: Modifier = Modifier,
    onClick: () -> Unit
) {
    Surface(
        modifier
            .selectable(
                selected = isSelected,
                onClick = onClick
            )
            .defaultMinSize(minWidth = 48.dp, minHeight = 48.dp)
    ) {
        Column {
            Text("Item", color = if (isSelected) MaterialTheme.colorScheme.primary else MaterialTheme.colorScheme.onBackground)
        }
    }
}

Screen Recording 2023-02-10 at 01.35.25.mov

[Djaka Pradana Jaya Priambudi]

Notice the blue color doesnt changed in second video unlike the first one

[Djaka Pradana Jaya Priambudi]

Tested in:
Kotlin: 1.7.21 & 1.7.20
Compose: 1.4.0-alpha02, 1.3.2

[Alex Vanyo]

Could you try with the latest 1.4.0-beta01 release?

[Djaka Pradana Jaya Priambudi]

there's no 1.4.0 beta01 in my gradle

Could not find androidx.compose.compilercompiler1.4.0-beta01.

[Alex Vanyo]

Ah sorry I was mistaken, 1.4.0-beta01 for the non-compiler versions, 1.4.1 for the compiler version

[Alex Vanyo]

I believe this is https://issuetracker.google.com/issues/254918865 which was a compiler issue that should be fixed with compiler 1.4.1.

[Djaka Pradana Jaya Priambudi]

ahh i see, i tried to find similar issue in issue tracker but can't found it. Thanks for the suggestion, will checkout later