https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
v

Vampire

02/13/2023, 5:17 PM
There is currently no way to get custom outputs from an action that does not have outputs at all, for example because it was modelled wrongly or because the outputs were just added by the action developer. If I were to create a PR to fix that, how would you prefer it? I see three options: • Make any action have custom outputs available • Make
ExternalActionStep
have a function
withCustomOutputs()
• Make
ExternalActionStep
have a property
withCustomOutputs
p

Piotr Krzemiński

02/13/2023, 5:41 PM
I'd try merging the concepts of action and action with outputs (since given what you wrote, any action can have outputs), so the first option seems to be the most compelling one
I have no way to play with the code now, so let's experiment
BTW, is it a real-life case or a hypothetical one? Could you show which action has this issue?
When browsing actions, I see various kinds of weirdness, like not using inputs and all and using env vars instead (I don't want to support this case in the lib)
v

Vampire

02/13/2023, 6:09 PM
Not sure how the last comment is related to my question. But yeah, it is actually a theoretical problem right now. When playing with how to set the
environment
in the other thread I had to search for an action that has outputs, and thought that all should potentially have outputs to keep the flexibility the lib has in most other places.
But yeah, it is actually a theoretical problem right now.
Does that mean you don't want that change until someone hits the problem and needed it or you would want it anyway if someone does the change? 😄
p

Piotr Krzemiński

02/13/2023, 6:38 PM
Let me put it like this: I'd like to track it as an issue in GH and focus on real problems/missing features first :)
Of course, if you prepare a PR, I'll appreciate it, but bear in mind that it will consume some of my resources to review and discuss, and maybe you'd prefer me to help with or implement another feature
v

Vampire

02/13/2023, 10:42 PM
Yeah, it's a dance on the volcano 😄
But no risk no fun 🙂
I gave it a shot and it was not that much changes, when ignoring the generated classes and test fixtures. 🙂
And it has the additional advantage that all output classes now share a common base class
p

Piotr Krzemiński

02/14/2023, 6:47 AM
Cool, thanks! Before I review, could you resolve the conflicts?
v

Vampire

02/14/2023, 9:49 AM
Ouch, that package refactoring is pure poison for that one. 😄
Sure, I'll rebase it of course
Done
p

Piotr Krzemiński

02/15/2023, 9:34 PM
@Vampire thank you, it's not only a feature but also simplification of internals ❤️
v

Vampire

02/15/2023, 10:10 PM
Yep, with no distinction necessary it simplifies things of course :-)
p

Piotr Krzemiński

02/15/2023, 10:11 PM
can I also ask you to update the docs? unfortunately we don't yet have kotlinx-knit (or equivalent) that would have catch it in the original PR
@Vampire ping - I’m planning to release tomorrow, let me know if you’re able to fix it or I should do it
p

Piotr Krzemiński

02/16/2023, 11:49 AM
CI now fails, I also see some other minor issues I’d like to discuss - are you fine with just fixing the docs for tomorrow’s release, and making this refactoring as a separate PR without rush?
v

Vampire

02/16/2023, 11:54 AM
Oh no. 🙈 Sure, no problem.
change incorporated and CI for the other PR should also be green now
p

Piotr Krzemiński

02/16/2023, 12:08 PM
awesome, thanks! will take care of them today evening
v

Vampire

02/16/2023, 1:10 PM
rebased 🙂
p

Piotr Krzemiński

02/16/2023, 7:09 PM
great job, danke 🙇
v

Vampire

02/16/2023, 7:11 PM
Immer gerne :-)