hello :wave: is there a way to update already configured routes? i.e. got a plugin that configures r...

# ktor

[Dariusz Kuc]

hello 👋
is there a way to update already configured routes? i.e. got a plugin that configures routes but some folks would like to add some processing around it (e.g. authentication)

[Aleksei Tirman [JB]]

How exactly the plugin configures routes?

[Dariusz Kuc]

👋 based on the user config we configure some routes -> https://github.com/ExpediaGroup/graphql-kotlin/blob/master/servers/graphql-kotlin-[…]src/main/kotlin/com/expediagroup/graphql/server/ktor/GraphQL.kt

[Aleksei Tirman [JB]]

With the above implementation, you can’t. You can extract your routes into a separate method with the Route type receiver, to give the users ability to call it in any place in the routing. Inside that method, you can acquire an instance of your GraphQL plugin to configure the routes using the GraphQLConfiguration .

[Dariusz Kuc]

by any chance do you know of some example code that I could look up? somewhat confused how would I get an instance of the plugin in other places

guessing you are suggesting a pattern similar to what authenticate plugin does, i.e.

install(Authentication) {
  // configuration
}
install(Routing) {
  authenticate(<config>) {
    // route config
}

[Aleksei Tirman [JB]]

Yes, exactly.

[Dariusz Kuc]

how would I get access to my plugin from route though?

[Dariusz Kuc]

sticking stuff up to ApplicationCall#attributes ? or is there some better way

[Aleksei Tirman [JB]]

You can get an instance of the plugin by call.application.plugin(<PluginClass>)

[Dariusz Kuc]

👍

[Dariusz Kuc]

is there a way to ensure that routes get created by default? i.e. if someone does not install routing I'd like to autoconfigure the defaults

[Dariusz Kuc]

guess could expose it as

install(GraphQL) {
  // config
}
install(Routing) {
  graphQLRoute() // <-- requires explicit user config
  graphiQLRoute()
}

[Aleksei Tirman [JB]]

In this way you can’t ensure that.

[Dariusz Kuc]

but if I don't do it this way then folks cannot configure auth stuff 😞 so guess kind of have to

[Dariusz Kuc]

thanks

[Aleksei Tirman [JB]]

Generally, this can be solved by a documentation.

[Dariusz Kuc]

another follow up question

[Dariusz Kuc]

I was installing ContentNegotiation globally by

pipeline.install(ContentNegotiation) {
  jackson(streamRequestBody = config.server.streamingResponse) {
    apply(config.server.jacksonConfiguration)
  }
}

but this was breaking users who wanted to use different content negotiation on some other routes

[Dariusz Kuc]

someone opened up the PR that moved it to the routing block -> https://github.com/ExpediaGroup/graphql-kotlin/pull/1684

[Aleksei Tirman [JB]]

Yes, you can install the ContentNegotiation plugin into specific routes

[Dariusz Kuc]

sounds like the fix was not correct -> it should be applied per route

[Dariusz Kuc]

👍 i'll fix it up with the refactor

[Dariusz Kuc]

thanks