Hi. I used KVision to build the frontend of this project and I would like your feedback regarding its usage including any criticisms and suggestions. Thanks.
r
Robert Jaros
02/15/2023, 6:47 AM
Looks cool, clean and readable.
I would definitely remove all unused KVision modules to save bundle size.
Or you can make use of them - e.g. you can use Imask module to enhance you form fields with masked phone number and or email.
I would probably drop
required
for some form fields (e.g.
Note
)
And last but not least 😉 When implementing endpoint you are using three separate "facades" to save data to the database. Every facade is using transaction to save the data. But in my opinion you are missing transaction for the whole operation. Saving a contact should be an atomic and transactional operation. Unfortunately I'm not using exposed so I don't how to do it correctly.
If you don't mind, I would be happy to add a link to your project as an example on KVision website.
a
Andromadus Naruto
02/15/2023, 7:09 AM
I've not explored Imask but I'll check it out soon.
Okay. Sorry regarding the database transaction, that's really an issue. There's a way to use a transaction scope across multiple calls but I didn't want to include database logic in the endpoint service. I'm going to do more investigation on that today.
Or what do you think?
I also have few updates planned:
• Global Loading state (using Pace or something similar to the one used in some of your production apps)
• Global Dispatcher for Notifications Events (I doubt I might change from Toast but who knows...)
• Authentication
• Task Management