Does the position, where you call `remember`, matt...

# compose

[Peter Mandeljc]

Does the position, where you call remember, matter? Should 2nd code be preferred?

// 1st example
var shouldShowOnboarding by remember { mutableStateOf(true) }
Surface(modifier) {
    if (shouldShowOnboarding) {
        OnboardingScreen()
    } else {
        Greetings()
    }
}

// 2nd example
Surface(modifier) {
    var shouldShowOnboarding by remember { mutableStateOf(true) }
    if (shouldShowOnboarding) {
        OnboardingScreen()
    } else {
        Greetings()
    }
}

[Peter Mandeljc]

I guess performance wise, it won't matter much, since Surface will not get recomposed. But I'm still wondering.

[Csaba Szugyiczki]

As a rule of thumb, you should create these state variables on the lowest level possible. If you do not want to change the value of shouldShowOnboarding from a higher level then do not hoist it, leave it as close to the usage point as possible.

[Csaba Szugyiczki]

So yes, I would go with the second variant of this example

[Peter Mandeljc]

I guess you mean that only from code readability perspective?

[Csaba Szugyiczki]

Yes, readability and cleanliness.

I don’t think it would have performance or any other penalties to have it higher within the same Composable function

[Peter Mandeljc]

yeah, I strongly agree with that. But still, I guess by doing 1st example, compose has to do a bit more checks, if Surface needs to be re-composed? Not worried about performance, just to satisfy my curiosity 🙂

[Csaba Szugyiczki]

I think that would be true only if shouldShowOnboarding was a parameter of Surface

[Peter Mandeljc]

thanks for info! 🙂

[Csaba Szugyiczki]

No problem! 🙂