https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
d

David Kubecka

02/22/2023, 10:43 AM
Why the compiler is complaining here, i.e. can't auto-cast?
enum class DateAttribute : UpcomingPaymentAttribute

data class DateKey(val startDate: LocalDate, val granularity: DateAttribute)

...
            // it is UpcomingPaymentAttribute
            when (it) {
                DateAttribute.DAY -> DateKey(LocalDate.now(), it) // here compiler complains that it is UpcomingPaymentAttribute, not DateAttribute
c

CLOVIS

02/22/2023, 10:49 AM
Is
it
a
var
? What's the compiler message?
d

David Kubecka

02/22/2023, 10:56 AM
Type mismatch: inferred type is UpcomingPaymentAttribute but DateAttribute was expected
it
is just the standard "default" variable
c

CLOVIS

02/22/2023, 10:57 AM
Could you reproduce it on https://play.kotlinlang.org/? There's not enough information to understand what the problem is
g

Goetz Markgraf

02/22/2023, 12:43 PM
Why should
it
be of type
DateAttribute
? I don’t see any cast.
it
is of Type
UpcomingPaymentAttribute
. In the
when
expression, I see that
it
is compared to a value of
DateAttribute.DAY
. But that does not include, casting
it
to
DateAttribute
. If you had a
is DateAttribute
in the
when
expression, than the compiler would cast.
d

David Kubecka

02/22/2023, 12:48 PM
I see. But if
it == DateAttribute.DAY
then surely
it is DateAttribute
🙂 Can I somehow help the compiler realize that (other than manual cast)?
c

CLOVIS

02/22/2023, 12:56 PM
No, you can override equals. If you used
===
, then sure.
g

Goetz Markgraf

02/22/2023, 1:01 PM
I was able to reproduce your situation:
interface Parent

enum class Child : Parent {
    THREE, FOUR
}

fun doIt(param: Child) {
    println (param)
}

val a: Parent = Child.THREE

when (a) {
    Child.THREE -> doIt(a)
    Child.FOUR -> {}
}
Two solutions:
when {
    a is Child && a == Child.THREE -> doIt(a)
or
when (a) {
    Child.THREE -> doIt(a as Child)
I’d prefer the second variant. I agree with you that the compiler actually should be able to cast that.
c

CLOVIS

02/22/2023, 1:04 PM
I disagree with you, I much prefer the first variant. With the first variant, nothing can go wrong. With the second variant, if someone ever overrides
equals
with a dumb implementation (which would indeed be dumb, but it could happen), it'll crash with ClassCastException, which will be hell to debug.
d

David Kubecka

02/22/2023, 1:48 PM
you can override equals
That's the explanation I was looking for. Thanks! Although, the consequences are kind of unfortunate because either I will do the explicit cast/check, or go with
===
losing the exhaustiveness of
when
c

CLOVIS

02/22/2023, 1:50 PM
In this case, I would write:
when (it) {
    is YourEnum -> when (it) {
        YourEnum.FirstElement -> …
        YourEnum.SecondElement -> …
    }
    else -> …
}
It's much easier to understand what happens, you have the smart cast and exhaustive checks, and it's probably faster (the inner
when
on the JVM can be compiled to a native
switch
)
g

Goetz Markgraf

02/22/2023, 1:52 PM
@CLOVIS Thanx, I did not think of this. Again a good reminder, why class cast in kotlin is (almost always) a bad idea.
c

CLOVIS

02/22/2023, 1:52 PM
Rule of thumb: if the compiler doesn't trust your
is
check, you shouldn't either
k

Klitos Kyriacou

02/22/2023, 3:31 PM
Can you give me some sample code in which a silly definition of an overridden
equals
can lead to unexpected behaviour? I couldn't get it to misbehave the way @CLOVIS suggests:
interface Parent

object O : Parent {
    override fun equals(other: Any?): Boolean {
        return true
    }
}

enum class Child : Parent {
    ONE, TWO;
}

var o: Parent = O

fun main() {
    println(o.equals(Child.ONE)) // true
    println(o == Child.ONE)  // false!
    val n = when (o) {
        Child.ONE -> 1
        Child.TWO -> 2
        O -> 3
        else -> 4
    }
    println(n)  // 3, not 1
}
So it seems that the
when
expression will choose the enum value only when the variable is an actual enum type.
c

CLOVIS

02/22/2023, 3:37 PM
Ouch this is so much worse than I thought. On the JVM it uses the enum identity (playground), but on JS it uses the object equality (playground), so this code behaves differently depending on the platform
k

Klitos Kyriacou

02/22/2023, 5:27 PM
Upvoted. Related is the fact that on the JVM (but not on JS) the
==
operator doesn't seem to call
equals
(playground). This contradicts the language spec and the documentation.