Hello guys! We’ve a <new issue >created about ClosedScopeException. Basically, this <piece of code...

# koin

[Pedro Francisco de Sousa Neto]

Hello guys!

We’ve a new issue created about ClosedScopeException.

Basically, this piece of code scope.close() from registerScopeForLifecycle is running BEFORE activity onDestroy.

So if developer is calling something injected in onDestroy, gets a crash.

Any suggestions to handle this case? Because this start happen in our app when we bump version from 3.1.6 to 3.3.1.

[Pedro Alberto]

so I assume you are using

createActivityScope

[Pedro Alberto]

when you say

So if developer is calling something injected in onDestroy, gets a crash.

Can you give a sample ?

[Pedro Francisco de Sousa Neto]

I’m using ScopeActivity. And yes, it’ll use

fun ComponentActivity.activityScope() = lazy { createActivityScope() }

[Landry Norris]

Maybe try to track with a boolean if the presenter is initialized? No need to load the presenter just to dispose it if it hasn’t been loaded yet.

[Pedro Francisco de Sousa Neto]

I totally agree with you about to refactor. But the point is the crash is happening and was not expected to happen.

Right now, I think my question was wrong. I’m not trying to fix the problem (it’s easy) but I want to know why the Koin code was changed the observer from 3.1.6 to 3.3.1.

It impacted a lot of activities to crash.

[arnaud.giuliani]

let me check if I can move things around 👍

[arnaud.giuliani]

tracked the issue for 3.4.0 milestone

[Pedro Francisco de Sousa Neto]

Thanks, @arnaud.giuliani! blob smile happy