I'm using binary-compatibility-validator and kotlinx.serialization synthetic constructors show up in the API dump (the ones that take a

SerializationConstructorMarker

as last parameter). My understanding is that they're only used from the companion serializer. Would it be possible to hide them? Maybe make it internal? Or do they need to actually be public?

Doesn’t it make sense that it’s part of the API? If you remove the @Serializable, consumers will no longer be able to use your type with KxS out of the box. 🤔

I'm OK with Companion and serialiser being public. But the synthetic class constructor is an implementation detail IMO

are the constructors annotated with anything? For example,

@JvmSynthetic

? https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.jvm/-jvm-synthetic/ If they were, could BCV be set to ignore them?

Been thinking about that but I don't think BCV can ignore all synthetic symbols. If you take default arguments for an example, they're also using a synthetic method and this one is part of the binary API

yeah good point. It looks like the constructors are annotated with

@Deprecated

though. You could argue that all deprecated declarations should be excluded from the

.api

?

Deprecated methods are still necessary for compatibility. I think it’s dangerous to filter them

alternatively, you could a

doLast {}

in the Gradle tasks with some regex remove them from the

.api

files

I'm thinking marking it internal in the Kotlin Metadata would work

do you have an example of what you want to exclude from the

.api

?

There's a lot more to this PR but it's basically this: https://github.com/apollographql/apollo-kotlin/pull/4702/files#r1117640434