Funky issue I've got. I'm using `AndroidView` wit...

# compose-android

[Colton Idle]

Funky issue I've got.

I'm using AndroidView with a SurfaceView

If I have an if statement to show/hide the AndroidView... it renders the first time, but if the if statement flips to false and true again, the AndroidView won't render. 🧵

[Colton Idle]

@Composable
fun MyAndroidView() {
  AndroidView(
      factory = { ctx ->
        SurfaceView(ctx).apply {
          Log.e("TEST", "apply")
          this.holder.addCallback(
              object : SurfaceHolder.Callback {
                override fun surfaceCreated(holder: SurfaceHolder) {
                  Log.e("TEST", "created")
                }

                override fun surfaceChanged(
                    holder: SurfaceHolder,
                    format: Int,
                    width: Int,
                    height: Int
                ) {
                  Log.e("TEST", "changed")
                }

                override fun surfaceDestroyed(holder: SurfaceHolder) {
                  Log.e("TEST", "destroyed")
                }
              })
        }
      })

}

[Colton Idle]

The logs I get initially:

apply
created
changed
changed

then when my if statement flips to false

destroyed

then when it flips back to true

apply
Why doesn't it get created?!?

At that point if I press a button (like press it down and don't release it) it will go ahead and do

created
changed
changed

Something just feels wrong here

[Joel Denke]

I think you want to move apply block after Surface View to AndroidView setup method. Factory only called once upon creation I think. Setup block called each recomposition.

[Joel Denke]

See sample at https://developer.android.com/jetpack/compose/migrate/interoperability-apis/views-in-compose
Argument called update what I referred to as setup.

[Joel Denke]

For callback I also think potentially need rememberupdated and store outside AndroidView to remember it not recreated each time view recomposition or inflates.

[Colton Idle]

Interesting point with remember of the callback. I guess I can try that.

[Joel Denke]

Its a little complicated how compose evaluates lambda expressions if they refer to stateful compose states. You want updating lambda when that happens but keep lambda itself. Helped me a lot of times but also confusing me. Potentially solves part of your issue. As I dont know rest of code not sure.

[Colton Idle]

Yeah. when im back at my desk i will give this a try

[Joel Denke]

Also can be bugs under hood. Mixing AndeoidView interop not always play nice, like nested scrolling in Webview. Could be some ui frame updating in SurfaceView behaves different. But I am no expert :)
I just avoid AndroidView in compose as much as possible.

[Colton Idle]

Yep. I wish I could avoid it here.

[vide]

Hey @Colton Idle, did you ever figure out what is happening here?

[Colton Idle]

I filed a bug I believe and I think they said something fixed it. lemme look

[Colton Idle]

Nope. Apparently wasn't fixed: https://issuetracker.google.com/issues/285718058

[Colton Idle]

my fix was changing the size on the if statement as well. I just added like 2 dp to the size. No one noticed the difference in height, but it did fix the issue.

[vide]

Thanks for the info! I'm running into this same bug 😰

[Colton Idle]

oh hot damn. def reply to that same issue tracker. i can try to go back to my code and retry things if it helps.

[Colton Idle]

just out of curiosity. what are you using the surface view for?

[Colton Idle]

im showing a usb camera output in mine. 😅

[vide]

I'll get back to this when I'm working again after the holidays 😄

[vide]

The surface is used for media playback, streaming video for example so quite important to be working 😅

[vide]

It seems like the issue is that the onSurfaceCreated is not called before something else draws to the screen. I tried your minimal reproduction project, but I couldn't reproduce it with that

[vide]

I also tried making my own minimal reproduction but not reproducable with that either... seems to be multiple conditions to get it to break

[vide]

But in the place that it currently does break it does every time

[vide]

Requires a specific api level too