Would y'all be open to a PR to expand `Resolver.ge...

# ksp

[Zac Sweers]

Would y'all be open to a PR to expand Resolver.getDeclarationsFromPackage() to allow including subpackages too? We have a good use case for this in Anvil

[Jiaxiang]

What do you mean by subpackage?

[Zac Sweers]

Give com.example, I want to also fetch com.example.subpackage

[Zac Sweers]

But I only know about the first one at processing-time

[Zac Sweers]

This is possible with the underlying module itself, just would like to avoid using a private API to achieve the same result :)

[Jiaxiang]

I see, that looks doable from implementation side, caveat is that this API have the potential of extracting the whole classpath out though.

[Jiaxiang]

alternatively, what if we just provide an API to give you a list of subpackages under a pacakge name? So that you can subsequently use the package names to get the declarations using existing API?

[Zac Sweers]

yeah that would work too 👍

[Zac Sweers]

we want from dependencies too, not just sources. In case it matters

[Jiaxiang]

That should be fine, we already return symbols from dependencies for getting from package.

[Zac Sweers]

awesome. Should I file an issue summarizing this?

[Zac Sweers]

or just go straight for the PR?

[Jiaxiang]

Sounds good, please go ahead with an issue to begin with.

[Zac Sweers]

https://github.com/google/ksp/issues/1795

[Zac Sweers]

do you want me to try a PR?

[Jiaxiang]

That should also work if it fits your bandwidth 🙂

[Zac Sweers]

Will do

[Zac Sweers]

I’m also still working on that module name PR, but waiting for a response here: https://kotlinlang.slack.com/archives/C03PK0PE257/p1710253118543569?thread_ts=1709960362.349149&channel=C03PK0PE257&message_ts=1710253118.543569

[Zac Sweers]

Does the ResolverAAImpl do the inverse of this by coincidence? The code appears to gather all the symbols of parent packages as well as the requested package

[Jiaxiang]

it was intentional, the reason for the code is that you might get multiple package symbols for same package name therefore you need to visit all package symbols and filter by name and union them.

[Zac Sweers]

interesting, and not necessary in KSP1's impl?

[Jiaxiang]

yes, they are different

[Zac Sweers]

initial impl here: https://github.com/google/ksp/pull/1796. Working on tests next