I would have merged this <@U01681FLZC2> PR <https:...
# kotest-contributorso
Oliver.O
06/17/2024, 2:02 PMI would have merged this @Adam S PR https://github.com/kotest/kotest/pull/4105 immediately, bypassing branch protections to avoid re-running those pointless flaky tests we're still trying to weed out. But it seems there is no way to do that without stealing the commit (it suggests to use my own account, which would be very unfair). Is there any other way to achieve that? Or did I misunderstand things and the commit would not appear to be authored by me?
a
Adam S
06/17/2024, 2:05 PMhmmm good question, I'm not sure what GitHub will do. I know sometimes it says 'co-authored' and will credit both
Adam S
06/17/2024, 2:06 PMI think this commit bypassed the protections, and it credits me and @Emil Kantis https://github.com/kotest/kotest/commit/e30673853dcabdae2cdbd2094ddb73f3c2068650
Adam S
06/17/2024, 2:08 PMI merged it anyway :)
o
Oliver.O
06/17/2024, 2:13 PMIt seems this "co-authored" results from resolving the "out of date with the main branch" by button-click. Thanks for merging!
a
Adam S
06/22/2024, 8:42 AMI bypassed branch protections for your PR https://github.com/kotest/kotest/commit/f1c11fce62c41e53fc0f982c22d3375f712b7c73, and the commit is 100% you :)
o
Oliver.O
06/22/2024, 8:44 AMCool, thanks for the info. So we can safely do so. 🎉
Oliver.O
06/22/2024, 8:48 AMRegarding the time source, I have tried to orient myself via one of your PRs. Maybe I have missed something. I’ve always been thinking the coroutineTestScope uses runTest which in turn enables virtual time. Will look that up.
👍 1
5 Views