A modern programming language that makes developers happier.

kotlinlang

Hey guys, i have added
```viewModel { MainViewModel() }```
in koin module and injecting the view model with
```val mainViewModel: MainViewModel by viewModel()
val mainViewModel2 = getViewModel&lt;MainViewModel&gt;()```
these both ways and setting value in one composable, and injected the same viewmodel in similar way in other composable, but instead of returning the existing instance it always returns new instance of that view model in the composable, can anyone help me with this?

Can you clarify what you mean by it _always_ returns a new instance of that ViewModel? What is your expectation?

for eg: lets say i have a main viewmodel
```data class Test(val isSomething:Boolean)

class MainViewModel() :ViewModel(),
    KoinComponent {
    var test = mutableStateOf&lt;Test?&gt;(null)
}
class KoinCoreModule {
    val koinCoreModule = module {
viewModel { MainViewModel() }
}```


now in mainactivity in setcontent i am injecting and setting the test value of that viewmodel
```setContent {
    //Injecting via Koin DI and in compose way
    val mainViewModel = getViewModel&lt;MainViewModel&gt;()
mainViewModel.test.value = Test(true)
}```

The `viewModel`  DSL of Koin uses `factory{}`  under the hood. This means by default you get a new instance every time you inject it; *unless your are in the same scope as a previously obtained instance* (I might have absolutely murdered the definition there).

In your case your MainActivity and HomeContent each have their own owners so you'll get different instances when you inject into them. What you are actually looking for is a shared ViewModel.

I'm not entirely sure how you would implement that for your usecase though.

Please keep the conversation in this thread instead of "Send to channel" every time.

It is definitely possible to inject shared viewmodels. I've done it with navgraph scoped viewModels. However in your case you want to share a ViewModel between an Activity and a Composable. I think it should be possible but I don't know how.

oh ok, thank you so much for your replies