rocket

Question

rocket The highlight of this release is moving away from handcrafting YAML and delegating it to instead the same library that s used in This way several known issues with invalid YAML got fixed and the library became simpler It will result in slight formatting changes of your output YAMLs and hopefully no regressions slightly smiling face

Piotr Krzemiński · Answer

first regression sweat <https github com krzema12 github actions kotlin dsl issues 416>

Piotr Krzemiński · Answer

you may want to wait with upgrading to v0 25 0 until it s fixed

Piotr Krzemiński · Answer

I need your help The author of snakeyaml agreed to add a feature that would fix the bug <https bitbucket org snakeyaml snakeyaml issues 541 ability to disable emitting anchors|https bitbucket org snakeyaml snakeyaml issues 541 ability to disable emitting anchors> can someone contribute within a week before they release I may not be able to time wise

Piotr Krzemiński · Answer

< jmfayard> < Nikky> < LeoColman> maybe you have a spare moment point up pray

Nikky · Answer

i probably won t have to the time to decipher snakeyaml s source

Piotr Krzemiński · Answer

I have something <https bitbucket org snakeyaml snakeyaml pull requests 17 541 allow disabling anchors when dumping>

Nikky · Answer

looks like what i came up with

LeoColman · Answer

You guys are uber quick

LeoColman · Answer

I didn t even have time to see it

Nikky · Answer

problem with that approach is snakeyaml will crash with a stackoverflow exception when dealing with any kind of recursiveness

Nikky · Answer

as long as that is properly communicated documented though

Piotr Krzemiński · Answer

Yeah already pointed out by the author in the PR I ll add a test for it

Vampire · Answer

Kaml doesn t output anchors like that so I d guess it is possible with pure Snakeyaml too I started to factor out my DAOs into a standalone lib to eventually make it usable in your lib just need a bunch more of tests for it and have limited time but I just created a ```on pull request push ``` in a quick test without problem or special handling

Piotr Krzemiński · Answer

To be frank I m still not convinced that kaml is the best choice here I d appreciate a PoC that would show how your DAOs would be used in the DSL lib

Piotr Krzemiński · Answer

I find snakeyaml pretty convenient not counting this anchors issue that s likely to be fixed soon ish

Vampire · Answer

Don t worry I m not just doing it for you slightly smiling face

Piotr Krzemiński · Answer

< Nikky> got a moment to check out

Nikky · Answer

got no account on bitbucket and when i tried to import the mavne project into idea there were a few warnings about inability to resolve plugins what can i do to help

Nikky · Answer

that means catching serialization in snakeyaml when it runs into recusion and throwing not sure i have the mental capacity for that today

Piotr Krzemiński · Answer

Probably something along these lines It s fine no forcing from my side it would be cool to tackle it early next week so that the feature gets into their next release also next week I ll also try to find time for it but no guarantees

Piotr Krzemiński · Answer

What actually worries me most is snakeyaml s infrequent release schedule like every half a year from what I ve seen

Piotr Krzemiński · Answer

Plan B is to temporarily copy snakeyaml s code into the DSL lib with the feature added just to address the anchors issue Then promptly merging the PR in snakeyaml becomes less critical

Piotr Krzemiński · Answer

fix is merged I ll release it together with next usual release that is probably on Friday