The OpenSavvy fleet is migrating from JVM toolchai...
# opensavvy
c
The OpenSavvy fleet is migrating from JVM toolchains to Tapmoc πŸ‘€
πŸš€ 3
🐾 1
p
Cool! I've been thinking of doing the same for our projects, but for whatever reason, I wasn't feeling comfortable in doing so. πŸ˜… How has the migration been?
c
@mbonnin helped me do it, but honestly it was pretty seamless. You can find the full changes in our conventions repo. The main reason we wanted to go through it is because we are constantly being rate-limited by FooJay, so our CI fails often for no reason.
gratitude thank you 1
m
I'm happy to help if you have any question @Paulo Cereda
gratitude thank you 1
p
@CLOVIS @mbonnin Hi friends! Just passing by to mention that we successfully migrated a project to using
tapmoc
, and now I am including it in other projects as well. It's been pretty smooth, thanks! gratitude thank you The only "caveat" (and this is not `tapmoc`'s fault) is that now I need to explicitly mention the
jvmTarget
to
detekt
(I suspect it used to rely on
jvmToolchain
), but it's just a 3-line addition. πŸ˜‰ Cheerio!
πŸŽ‰ 1
c
Congrats!
gratitude thank you 1
m
Nice! Thanks for the feedback!
gratitude thank you 1
I suspect it used to rely on
jvmToolchain
probably worth a feature request if it's the case
p
@mbonnin I noticed
detekt
gets the value for the JVM target from the compiler configuration, so that would explain why things just work when
jvmToolchain
is used. πŸ˜‰ I am happy to set the value manually, but it could be an interesting feature. Thanks for considering! (and of course for working and maintaining such cool project!)
m
JVM target from the compiler configuration,
I would expect this to match what tapmoc is using πŸ€”
Do you happen to have the place in detekt where this is done?
@Paulo Cereda, did you get an error like
Copy code
Invalid value passed to --jvm-target, expected one of ...
?
If that's the case, I think this is fixed in Detekt 2.0. At least I haven't been able to reproduce there
p
@mbonnin Yes, that's the error I get. πŸ˜… Apologies, I haven't tested the 2.x branch yet (I think it's still in alpha), but I am happy to try! So sorry for the noise! (also @CLOVIS sorry for "hijacking" your thread πŸ˜…)
πŸ‘ 1
c
Ahah no worries, it was a thread to advertise Tapmoc anyway, this is on topic