```class IntentOpener(private val activity: Activi...

# getting-started

[ursus]

class IntentOpener(private val activity: Activity?) {

    private fun startActivity(intent: Intent): Boolean {
        val activity = activity ?: return false <-------------------
        activity.whatever()
        return true
    }
}

vs

class IntentOpener(private val activity: Activity?) {

    private fun startActivity(intent: Intent): Boolean {
        if (activity == null) return false <-------------------
        activity.whatever()
        return true
    }
}

Which variant is more idiomatic? First one shadows but doesn't rely on smart casts

[Youssef Shoaib [MOD]]

2nd one is more idiomatic since it avoids the unnecessary shadowing. You should definitely not be scared of smart casts!

This'd be better, but it depends on what whatever returns:

private fun startActivity(intent: Intent): Boolean {
        activity?.whatever() ?: return false
        return true
    }

[ursus]

Btw Is shadowing an issue? seems to compile fine and works correctly

[Youssef Shoaib [MOD]]

Not an issue. I just wouldn't use it if it's not needed. If activity was a var, then sure (although my variant still works then)

[ursus]

I see thank you!