Is it bad to put helper functions on a data class? For example say I have data classes that hold configuration/setting data for different kinds of actions. There can be lots of different types so it has a type field. Eventually I need to map it to the actual action class with business logic that uses the configuration/setting data. I could do a when(type) and instantiate respective action class and pass in the config data class. Or could I add something like: fun toActionClass(): SpecificActionClass = SpecificActionClass(this)

I'd define the function you gave as an extension function. Then it doesn't clutter the data class itself but is usable with that nice syntax in the scope you find appropriate

I don't see any problem in your conversion/map function, but don't add too much logic inside your Data Class.

@escodro So that's saying as long as it's a version method (toSomething) then it's fine?

🤷 It's a nice delineation of responsibility to me. It's not `Something`'s purpose to know what

SomeOtherThing

is, only to hold some data. Conversion function as extension or not is a one-liner either way.

@dMusicb I think so, in general. But if your app is separated in modules, for example, maybe this conversion should be done in a separate class, in the module where it would need to be converted. Otherwise it will not match the module scope.