Is there any way to remove this string? This funct...

# announcements

[pp.amorim]

Is there any way to remove this string? This function is not optional, I don't know why this is happening.

[gildor]

Remove which string?

[pp.amorim]

Thread.currentThread()

[leosan]

I don’t think the intrinsics check is added to the final bytecode, not sure though

[gildor]

Are we talking about LDC or about intrinsics?

[gildor]

intrinsics that checks for non null will be in final bytecode

[Dico]

Kotlin uses it to provide debug info when checking that it's not null.

[Dico]

Why do you need to remove it?

[Dico]

I think there's a compiler argument that prevents the check being emitted.

[gildor]

This compiler argument is semi-official and not recommended to use

[gildor]

such code will be optimized by HotSpot

[pp.amorim]

This function runs every 10ms

[gildor]

and?

[gildor]

You can remove this check by writing :

Thread.currentThread()?.isInterrupted

[pp.amorim]

I think it's heavy to init a string every 10ms 😄, the process of this function is very light

[gildor]

I don’t think so

[pp.amorim]

I am working dealing with UI too

[Dico]

it doesn't init a String at all, it's stored in a constant pool.

[gildor]

I don’t believe that you get any measurable difference

[pp.amorim]

hmm

[Dico]

It depends on the JVM.

[gildor]

this string will be cached in constant pool

[pp.amorim]

changing the topic, why Thread.currentThread().isInterrupted needs to be verified?

[gildor]

And I showed you how avoid this check

[pp.amorim]

it's not optional

[gildor]

First:
there is no “optional” in Kotlin, there is nullable

[gildor]

Second:
result of currentThread() has special “platform” type

[Dico]

Because it's a platform call, Java functions can all return null and Kotlin needs to check that it doesn't when you don't expect it to.

[gildor]

it means that it can be nulalble and non-nullable up to you, kotlin don’t know

[pp.amorim]

I am only targeting to Android so far

[Dico]

Love how were both explaining the same stuff simultaneously, I'll get out

[Dico]

Yeah, i think the check not null functions have a bigger impact on android. Don't quote me on that.

[gildor]

so I would just ignore this bytecode, it will be optimized and you never see any performance difference

[gildor]

but if it’s really bothers you, just use Thread.currentThread()?.isInterrupted == true instead

[pp.amorim]

no, I will try

[gildor]

And check docs about platform types:
https://kotlinlang.org/docs/reference/java-interop.html#null-safety-and-platform-types

[Dico]

Dalvik JVM does have redundant null check elimination, if that matters.

[pp.amorim]

@gildor worked! thank you!