I'm using a ListAdapter for one of my projects. An...
# androids
Sandesh Baliga
06/14/2020, 1:08 PMI'm using a ListAdapter for one of my projects. And i noticed that submitting a large list of items adapter.submitList(200+ items), is blocking the UI thread. Diffutil calculation was supposed to happen in background thread according to documentation.
I'm confused what's happening. Am I missing something?
s
Subhrajyoti Sen
06/14/2020, 2:18 PMCan you share your implementation of the DiffUtil? Maybe something's going wrong there and the recyclerview has to update all 200+ items
👍 1
s
Sandesh Baliga
06/15/2020, 12:31 PM@Subhrajyoti Sen
Here's the file. And in the appmodule class if i set initial page size to 100, it lags
https://github.com/skymansandy/goCoronaAndroidApp/blob/master/app/src/main/kotlin/dev/skymansandy/gocorona/presentation/main/india/adapter/CovidStatListAdapter.kt
j
Joost Klitsie
06/15/2020, 1:59 PMPerhaps it is your RecyclerView within a NestedScrollView? I never really use it, but you should check if your items are all drawn, or only the visible ones
s
Sandesh Baliga
06/15/2020, 2:03 PMYa it's in nestedscolview but with nestedscollinhEnabled set to false, also after the lag is done, I'm able to scroll smoothly over the entire list of items. I'm guessing something going wrong while drawing UI. Not really sure what's that
j
Joost Klitsie
06/15/2020, 2:04 PMcan you check how many of the 100 views are drawn the first time?
s
Sandesh Baliga
06/15/2020, 2:12 PMIt's like, after submitList, it lags like 5-10 seconds, then suddenly all items are drawn. Entire list
j
Joost Klitsie
06/15/2020, 2:12 PMI think that is the issue
💯 1
Joost Klitsie
06/15/2020, 2:12 PMrecyclerview should only draw the visible views
Joost Klitsie
06/15/2020, 2:12 PMnot the entire list
Joost Klitsie
06/15/2020, 2:12 PMso perhaps your listView expands the whole height
Joost Klitsie
06/15/2020, 2:13 PMinstead of the viewport only
Joost Klitsie
06/15/2020, 2:13 PMwhat might be because of the nesting
s
Sandesh Baliga
06/15/2020, 2:13 PMMaybe because it's inside nestedrecycleeview.
j
Joost Klitsie
06/15/2020, 2:13 PMyep, so you should check that out
s
Sandesh Baliga
06/15/2020, 2:14 PMIs that actual behaviour? When a recyclerview is inside nestedrecycleeview with nested scrolll false, does it actually draw entire view?
j
Joost Klitsie
06/15/2020, 2:14 PMI am not sure about it
s
Sandesh Baliga
06/15/2020, 2:14 PMYa probably. Checking it right away
Sandesh Baliga
06/15/2020, 2:14 PMMoving out of recyclerview
j
Joost Klitsie
06/15/2020, 2:14 PMalso I am not sure which flags to use within to avoid that
Joost Klitsie
06/15/2020, 2:14 PMalso you have the recyclerview nested within a linearlayout as well
s
Sandesh Baliga
06/15/2020, 2:14 PMNestedscrollview*
Sandesh Baliga
06/15/2020, 2:23 PM@Joost Klitsie damn bro that's the issue. I moved
Sandesh Baliga
06/15/2020, 2:23 PMI moved recyclerview out of nestedscrollview
Sandesh Baliga
06/15/2020, 2:24 PMAnd it's working fine now. Seems like recyclerview features aren't available inside nestedscrollview if nestedscollinhEnabled=false. Need to confirm on this though.
Sandesh Baliga
06/15/2020, 2:24 PMOutside of nestedscrollview, it's behaving normally. Thanks much man. I was not suspecting on nestedscrollview itself.
👍 1
2 Views