What is the general opinion of Using coroutines inside ViewModel. As blogged by @Sean McQuillan [G] in his blog https://medium.com/androiddevelopers/coroutines-on-android-part-ii-getting-started-3bff117176dd ViewModelScope automatically cancels any coroutine started inside ViewModel after onCleared is called

I would recommend not thinking in terms of “how can i use coroutines” but starting with an actual problem you need to solve, and determining if and how coroutines might be a useful tool to help solve it.

@Zach Klippenstein (he/him) [MOD] thanks for suggestion, Well I was actually trying to look from the same perspective

Can you describe your use case? Then we can discuss pros/cons of using coroutines for that case.

You can consider a simple MVVM flow as showcased in Jetpack View -> ViewModel -> Repository -> either Network or Local

It sounds like you'd probably benefit from something other than livedata, which was never really intended to be used as a generic async primitive outside of the UI. Are you actually working with streams of data, or just individual calls? If the former, you could use RxJava (Flow is too immature still unless you need multiplatform support). If the latter, you can replace your livedatas with suspend functions which have a much simpler API and compose nicer.

Well my case is one shot request to get data from server and have it displayed in UI

That looks right to me

Thanks man, well one more thing I would like to address here is wrapping the data from Repository into NetworkBoundResource obj,

I've never heard of

NetworkBoundResource

- is that type from a library?

Ah, it's a simple implementation of the repository pattern. You could implement this using the

liveData

builder to create LiveDatas from your suspend functions, but I would recommend using something like github.com/dropbox/Store instead - it is an actual repository library and has first-class coroutine support

But isn't it contradictory having LiveData exposed from the suspend func as it would break the core concept. As per my understanding from a ViewModel we can start a coroutine with a LiveData scope and call to repo to get data

But isn’t it contradictory having LiveData exposed from the suspend func as it would break the core concept.

You’re right, but it looks like

NetworkBoundResource

is using the `LiveData`s from its abstract methods as single-emission futures, not as streams. This is very much not what

LiveData

was designed for, I would consider it a pretty big smell. Again, I’d much rather use a real repository library like Store than copy/pasting (likely obsolete) sample code.

I echo with you on that. Thanks mate