Question regarding separation of concern in clean ...

# android

[Sagar Suri]

Question regarding separation of concern in clean architecture:
I have the following layer in my app:
1. UI
2. Presentation
3. Usecase
4. Repository
5. Data layer(Remote & Local data source)
Now I get a JSONArray from the remote data source. For simplicity the JSONArray consist of a list of the following `JSONObject`:

{
 "id": 1,
 "type": "city",
 "url": "<http://xyz.com/berlin.png>",
 "section": "world",
}

In my UI I want to show only list of Images. My UI should not get all a model which consist of URL. In which layer should I use a mapper to convert the ModelEntity to a Model which consists of URL only?

[Francisco Javier Ruiz Rodriguez]

I'd do it in Usecase

[Sagar Suri]

Reason being? @Francisco Javier Ruiz Rodriguez Just want to understand the valid points.

[Francisco Javier Ruiz Rodriguez]

Well, if in a future, you wolud like to show a list of images with the name of the city, you have to map it just in usecase, and if you want to reuse the code of the repository layer, you have all the object mapped 😄

[Sagar Suri]

Cool, make sense. How do you use presenter? What if I move this mapping logic in presenter? I am confused with the responsiblity of presenter and usecase now.

[turastory]

Well, I think conceptually there should be no logic in presentation layer, except communications with View. But moving all logics into use case.. would make too much boilderplate, so I usually put simple logics in ViewModel, and heavy logics in use case.

[Sagar Suri]

will you consider mapping the entity model to data model a lightweight logic? @turastory

[turastory]

No, because that involves 3rd party, something like network or database. In fact, I think you should put those mappers in data layer, because the json response totally depends on the remote data source.

[turastory]

Though I’m not sure about this.. Check out how other guys did. I recommend tivi app of Chris Banes: https://github.com/chrisbanes/tivi

[Francisco Javier Ruiz Rodriguez]

I usually have 3 data model, one for data/repository, one for use case and one for presenter/view, and the one for presenter have only the necesary params for the view, so the view doesn't have any data it doesn't need.
In usecase, I normally have all the data the views could need, because the usecase could be used in some parts of the app, but every application is different, so maybe for you is better to map it into presenter 🙂

[Hitender Pannu]

Total Agree with @Francisco Javier Ruiz Rodriguez here.
The main responsibility of presenter is to "decide and provide" the content to view layer.
it can use useCase in your case to get the actual data and create a mapper to provide the required content to view.

Generally we have one presenter for one view but use case can be used by multiple presenters.