hey, this code is throwing NPE, any ideas why? ``...

# android

[ar-g]

hey, this code is throwing NPE, any ideas why?

fun ConnectivityManager?.isConnected(): Boolean {
    return this != null && activeNetworkInfo != null && activeNetworkInfo.isConnected
}

Fatal Exception: java.lang.IllegalStateException: activeNetworkInfo must not be null

[Alexander Johansson]

Probably because isConnected doesn’t necessarily return a true/false value.

fun ConnectivityManager?.isConnected(): Boolean = this?.activeNetworkInfo?.isConnected ?: false

[michelfernandez]

a while ago I created a function similar to this ... I do not know if it helps you

@RequiresPermission(android.Manifest.permission.ACCESS_NETWORK_STATE)
fun Context.isNetworkAvailable(): Boolean {
    return try {
        val manager = getSystemService(CONNECTIVITY_SERVICE) as ConnectivityManager
        val networkInfo = manager.activeNetworkInfo
        return networkInfo != null && networkInfo.isConnected
    } catch (tr: Throwable) {
        false
    }
}

[Paul Woitaschek]

activeNetworkInfo is not a captures variable but a synthetic accessor.

[Paul Woitaschek]

So you are actually calling getActiveNetworkInfo() twice.

[Paul Woitaschek]

The first time you check if it’s null and the second time you call the getter again and call isConnected() on it. It looks like the second time it returned null.

[Paul Woitaschek]

So the correct solution seems to be:

[Paul Woitaschek]

this?.activeNetworkInfo?.isConnected == true