Make your `retrofitService.login` return `Observab...

# android

[edwardwongtl]

Make your retrofitService.login return Observable<LoginSealed.Success> instead of Observable<LoginSealed>

[droidninja]

But that results in typemismatch. Since i am returning LoginSealed.Failute in case of HttpException or IOException

[edwardwongtl]

Add a .map { it -> it as LoginSealed }

[droidninja]

Oh nice thanks. But in case of Success , response is null while there is some response from api.

[edwardwongtl]

Then maybe the field name is not match

[droidninja]

Actually fields name are the same. I even tried using Expose and SerializedName but still response is null.

[edwardwongtl]

Can you show the api response and your data class in detail?

[droidninja]

api response

{
  "session": "Not available",
  "returnMsg": "Invalid credentials",
  "returnCode": "401"
}

data class

data class WSResponse(
        @Expose
        @SerializedName("session")
        val session: String,
        @Expose
        @SerializedName("returnMsg")
        val returnMsg: String,
        @Expose
        @SerializedName("returnCode")
        val returnCode: String
)

[edwardwongtl]

Then it should be like
data class Success(val session: String, val returnMsg: String, val returnCode: String): LoginSealed()

[edwardwongtl]

Your Success have a extra wrapping layer so it does not fits the model

[droidninja]

That means i can't read success data class generic way?

[edwardwongtl]

How generic do you want? Keep in mind the data class structure needs to match the api response in terms of layer

[droidninja]

Like this

sealed class Result<out T> {
    data class Success<out T>(val data: T) : Result<T>()
    data class Error<out T>(val t: Throwable) : Result<T>()
}

But i think this won't work in my case. Right?

[edwardwongtl]

Won’t work, you need your api response to be the same structure for it to work
i.e. {"data": { ... } }

[edwardwongtl]

Unless you handle in yourself in a custom CallAdapter

[droidninja]

Oh okay. Thank you sir for the help, really appreciate that.

[edwardwongtl]

You’re welcome