https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-espaƱol
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamĆ”
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
k

Klitos Kyriacou

08/16/2021, 2:58 PM
Considering this class:
open class KotlinPractice(val id: Int) {
    override fun equals(other: Any?) =
        this === other ||
                other != null &&
                other::class == KotlinPractice::class &&
                (other as KotlinPractice).id == id

    override fun hashCode() = id
}
Is there a reason
other
is not smart-cast and instead I have to cast it to KotlinPractice manually?
l

Luke

08/16/2021, 3:06 PM
I can't answer why there is no smartcast, but you can do
this === other || (other as? KotlinPractice)?.id == id
šŸ‘ 1
e

edrd

08/16/2021, 3:11 PM
It's because the compiler doesn't perform smart casts when type checks are based on
::class
. You should use
is
instead:
open class KotlinPractice(val id: Int) {
    override fun equals(other: Any?) =
        this === other ||
                other != null &&
                other is KotlinPractice &&
                other.id == id

    override fun hashCode() = id
}
You could then also eliminate the
other != null
check as
is KotlinPractice
is checking that it's not a nullable type either:
open class KotlinPractice(val id: Int) {
    override fun equals(other: Any?) =
        this === other ||
                other is KotlinPractice &&
                other.id == id

    override fun hashCode() = id
}
k

Klitos Kyriacou

08/16/2021, 3:25 PM
Thanks, Eduardo, but I deliberately compared classes to comply with the requirement for
equals
to be symmetric. Unfortunately, when using
is
,
baseObj == derivedObj
does not imply
derivedObj == baseObj
.
šŸ‘ 1
e

edrd

08/16/2021, 3:42 PM
I think only if you override
equals
in
derivedObj
, otherwise it's symmetric:
open class KotlinPractice(val id: Int) {
    override fun equals(other: Any?) =
        this === other ||
                other is KotlinPractice &&
                other.id == id

    override fun hashCode() = id
}

class SubKotlinPractice(id: Int) : KotlinPractice(id)

fun main() {
    val kotlinPractice = KotlinPractice(1)
    val subKotlinPractice = SubKotlinPractice(1)
    
    println(kotlinPractice == subKotlinPractice) // true
    println(subKotlinPractice == kotlinPractice) // true
}
x is Y
means "x is of type Y or inherits Y"
v

Vampire

08/16/2021, 4:07 PM
Klitos is right with his concern. As long as it is not a sealed class, anyone could subclass
KotlinPractice
and overwrite
equals
, thereby most probably violating symmetry
Lukes approach is probably best as long as
id
stays non-nullable
k

Klitos Kyriacou

08/16/2021, 4:13 PM
Thanks, the fact anyone could override equals and break symmetry was exactly my concern. I think Luke's approach (elegant as it looks) is unfortunately still prone to symmetry violations.
v

Vampire

08/16/2021, 4:15 PM
Ah, yeah, you are right of course. Did get too less sleep it seems
Maybe this one then:
open class KotlinPractice(val id: Int) {
    override fun equals(other: Any?) =
        this === other ||
                other is KotlinPractice &&
                other::class == KotlinPractice::class &&
                other.id == id

    override fun hashCode() = id
}
The
is
also does the null-check, while then provides smart-cast for later. This is especially useful if you have more properties to check
k

Klitos Kyriacou

08/16/2021, 4:26 PM
Thanks, that's probably the best we can do for now, although this code checks the other class twice. I was wondering if there was any technical reason that the compiler couldn't do a smart cast after comparison of an instance's class.
e

edrd

08/16/2021, 4:28 PM
IDK either, but out of curiosity, you could use contracts to achieve smart casting for this use-case:
@OptIn(ExperimentalContracts::class)
inline fun <reified T> Any?.isOfType(): Boolean {
  contract {
    returns(true) implies(this@isOfType is T)
  }
  return this != null && this::class == T::class
}

open class KotlinPractice(val id: Int) {
  override fun equals(other: Any?) =
    this === other ||
      other.isOfType<KotlinPractice>() &&
      other.id == id

  override fun hashCode() = id
}
ā¤ļø 5