is this thread safe? It is not, right?

What do you mean by “thread safe”? You can call

value

and

accept

on a

BehaviorRelay

from multiple threads just fine. However if you call your

newJobs = …

update logic from multiple threads concurrently, there’s a race and your set could lose items. This can happen because both threads can read the relay’s value at the same time, each add their own `downloadJob`s, and then the first one to call

accept

will get overwritten by the second one.

yes the append is obvious, I meant the accept it self

Ah, so I was just wrong. I think that method is not safe because different subscribers could get values in different orders? But I’m not sure if that’s actually part of the rx contract.

weird is that's javadoc from base Relay and only copied to BehaviorRelay