And the asciidoc extension should probably added t...
# springs
sdeleuze
08/30/2019, 7:22 AMAnd the asciidoc extension should probably added to https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-docs/pom.xml
c
corneil
08/31/2019, 1:46 PMHow would you suggest going about collaborating with @ienoobong on the PR?
i
ienoobong
08/31/2019, 1:50 PMThere was a comment by Andy yesterday
https://github.com/spring-projects/spring-boot/pull/18017#issuecomment-526593835
Hence I’m not sure how to proceed
ienoobong
08/31/2019, 1:51 PMKindly advice @sdeleuze
c
corneil
08/31/2019, 5:52 PMThis seems like if there are runnable files referenced in the documentation we should be creating kotlin versions that are also runnable and test to reference.
If there aren't runnable versions of the Java it should be better to do that it the same time.
s
sdeleuze
09/02/2019, 7:44 PM@corneil @ienoobong Andy is ok if we provide Kotlin code snippets as runnable code as shown here : https://github.com/spring-projects/spring-boot/issues/6313#issuecomment-231035872. Any chance you could modify current PR into runnable Kotlin code to see if that works combined with Java/Kotlin tabs ?
c
corneil
09/02/2019, 7:48 PMWhat is the best way for multiple people to contribute to a PR?
s
sdeleuze
09/02/2019, 7:52 PMI guess @ienoobong could add you as contributor on his fork, but for now I would suggest you to fork it and point to your commit in a PR comment.
c
corneil
09/02/2019, 8:09 PMOkay will do so.
i
ienoobong
09/03/2019, 5:36 AMLooks good, will take that approach
ienoobong
09/03/2019, 5:38 AMAdded you @corneil
c
corneil
09/03/2019, 6:47 AMThanks
corneil
09/09/2019, 7:27 AMDo you think it would be best to have a separate profile in the Maven build for the Kotlin files which excludes the java files to ensure they can live side by side with same names?
corneil
09/09/2019, 7:28 AM@sdeleuze @awilkinson?
s
sdeleuze
09/09/2019, 7:29 AMI usually avoid same names (for test for example)
sdeleuze
09/09/2019, 7:29 AMSee for example
c
corneil
09/09/2019, 7:30 AMThat makes it simpler.
corneil
09/09/2019, 7:30 AM@ienoobong
s
sdeleuze
09/09/2019, 7:30 AMYeah if that possible that will avoid some troubles
sdeleuze
09/09/2019, 7:30 AMSo something like
Kotlin*sdeleuze
09/09/2019, 7:31 AMMaybe Andy will polish it differently for Boot but for the PR that will be fine IMO
i
ienoobong
09/09/2019, 7:35 AMOk, thanks!
3 Views