Contribution proposal: is there somebody intereste...

# spring

[sdeleuze]

Contribution proposal: is there somebody interested to translate Spring Boot code sample to Kotlin like I did on the Spring Framework refdoc? The refdoc is long but there are not so many code samples so I do think it is doable in a reasonable amount of time.

[ienoobong]

I am!

[sdeleuze]

Feel free to sync with @corneil to share the work if needed

[corneil]

I'll spend some time to get a first one in

[sdeleuze]

Make sense

[ienoobong]

@sdeleuze what branch do I start working from? master?

[sdeleuze]

Yes it is master, but I would suggest waiting for Corneil branch is order to avoid duplicated effort

[ienoobong]

I’ve synced with him, he said I can go ahead and he’ll only be able to spend much time until later today

[sdeleuze]

Oh great then

[sdeleuze]

So yes Boot master branch

[sdeleuze]

Tiny tricks, when you have annotated code with <1> You have to duplicate code comments for both Java and Kotlin and put an empty line between both (like I did on Framework).

[sdeleuze]

There may be style improvement to do but don't care for now

[sdeleuze]

I will see that with Boot team

[ienoobong]

I don’t understand what you mean by

when you have annotated code with <1>

[ienoobong]

I’ll submit a PR soon so I don’t go too far off

[ienoobong]

I’m starting with the using-spring-boot.adoc file

[sdeleuze]

https://github.com/spring-projects/spring-framework/commit/14558844bc4dba5586f6f9e27731bf52e802dcc5#diff-33156f3791e3a4cbf87c9b4789edc287R203

[ienoobong]

Okay, I get now. Thanks

[ienoobong]

Do I need to reference spring-projectsgh-21778 in my commits?

[sdeleuze]

Nope, just in the PR comment

[ienoobong]

Ok then

[ienoobong]

@sdeleuze I’ve created https://github.com/spring-projects/spring-boot/pull/18017

[sdeleuze]

@ienoobong @corneil I have seen the runnable code new commit 👍 How do you plan to move forward, have you already defined who do what to translate the code samples ? Any estimation of how many time will be needed ?

[corneil]

If this is the right track we will start moving forward and provide feedback in a day or so

[ienoobong]

Hi @sdeleuze, I’ve completed for using-spring-boot.adoc https://github.com/spring-projects/spring-boot/pull/18017

Would be great to get a review

[ienoobong]

All green!

[sdeleuze]

I have done a review, if you can't find how to avoid setting the Kotlin version please ask to Andy in the PR comments

[sdeleuze]

Thanks for taking in account my review.

[sdeleuze]

@ienoobong is it possible to give credentials to @corneil on your Boot fork in order to allow him to contribute some part of the Java -> Kotlin ? Could you split the work between both of you now that we have a stable basis ?

[ienoobong]

Hi @sdeleuze yes, I’ve added him to the fork. We’ll get back on the work splitting soonest.

[sdeleuze]

Great, thanks a lot for this great contribution

[sdeleuze]

I am a little bit pushee in order to let the time to Boot team to review and integrate it in order to be able to announce it at SpringOne Platform 😉

[sdeleuze]

Of course I will mention your names

[ienoobong]

No worries. I can understand. When is SpringOne coming up?

[ienoobong]

Less than a month away!

[sdeleuze]

October 7th but we will travel before and Boot team need some time to review and merge it. Ideally the PR should be merged in Boot 2.2 RC1 expected September 26th. https://github.com/spring-projects/spring-boot/milestone/144

[sdeleuze]

If that's possible of course

[sdeleuze]

Please let me know if you think that's doable after discussing with @corneil

[ienoobong]

Ok we will