well 73M that would fit on a zip drive :laughing:

# tornadofx

[bjonnh]

well 73M that would fit on a zip drive 😆

[altavir]

On Java 9+ you can use jlink plugin from the same author and it will be 2 times smaller.

[bjonnh]

I had issues with kotlin and that

[bjonnh]

I should try again

[altavir]

I managed to do it in the end. There is an example for tornado

[bjonnh]

yeah I couldn't get it to work

[bjonnh]

also I think it had an issue with producing windows version from linux

[altavir]

This one: https://github.com/beryx-gist/badass-jlink-example-kotlin-tornadofx

[altavir]

I had problems with split-packages, but not significant problems with jlink intself

[bjonnh]

interesting, I should try that again then

[bjonnh]

oh wait

[bjonnh]

but does the jlink plugin packs the JRE as well?

[altavir]

yep, it selects only needed module and packs jdk with exteranl executable handle

[bjonnh]

looks like that's what runtime does as well

[bjonnh]

it is calling jlink too

[altavir]

I can search for config with my packed application.

[altavir]

runtime packs the wholed jre. jlink selects only those modules you need

[bjonnh]

hmmm

[bjonnh]

weard because I'm setting which modules I want

[bjonnh]

and it dramatically reduced the size

[bjonnh]

runtime {
    imageZip.set(file("$buildDir/fractioncontroller-$version.zip"))
    options.set(listOf("--strip-debug", "--compress", "2", "--no-header-files", "--no-man-pages"))
    modules.set(listOf("java.desktop", "jdk.unsupported", "java.scripting", "java.logging", "java.xml"))
    targetPlatform("windows-x64", "jdk/13/win64")
}

[altavir]

Oh, probably it does the same, but does not infer module dependancies

[bjonnh]

and I think jpackage doesn't work with kotlin

[altavir]

jpackage is deprecated right now. Jlink is a separate tool and it does work with kotlin

[bjonnh]

javapackage is deprecated

[bjonnh]

oh yeah and jlink didn't work with logback

[bjonnh]

that's why I couldn't use it

[altavir]

jpackage is the name of new tool in jdk 14, which is not yet released

[bjonnh]

error: package javax.servlet does not exist
provides javax.servlet.ServletContainerInitializer with ch.qos.logback.classic.servlet.LogbackServletContainerInitializer;

[altavir]

http://logback.qos.ch/news.html

[altavir]

You must use 1.3.x for jigsaw compatibility

[bjonnh]

error: package kotlin.reflect.jvm.internal.impl.resolve does not exist
provides kotlin.reflect.jvm.internal.impl.resolve.ExternalOverridabilityCondition with kotlin.reflect.jvm.internal.impl.load.java.ErasedOverridabilityCondition,

[altavir]

Let me check if my old build works

[bjonnh]

ok I managed to get it working

[bjonnh]

it turns out it is slightly bigger

[bjonnh]

by a few megs

[altavir]

What javafx modules have you enabled?

[altavir]

The browser part is rather heavy

[bjonnh]

no I don't have that

[bjonnh]

oh there we go

[altavir]

My minimal distribution was about 35 - 40 megs

[bjonnh]

adding: options.set(listOf("--strip-debug", "--compress", "2", "--no-header-files", "--no-man-pages"))

[bjonnh]

oh yeah sure it didn't pack all of javafx

[bjonnh]

so it wont startc

[bjonnh]

ok I still have some stuff to manage

[bjonnh]

I liked the just plug it in approach of runtime

[bjonnh]

don't have to make a module info file

[bjonnh]

etc

[bjonnh]

oh and it is packing both linux and windows javafx

[altavir]

Yeah. Sadly JPMS is not widely adopted yet

[bjonnh]

error: module kotlin.stdlib.jdk8 reads package org.jetbrains.annotations from both annotations and checker.framework

[altavir]

kotlin stdlib has JPMS compatible artefacts, I am not sure, what is the difference though

[altavir]

https://discuss.kotlinlang.org/t/kotlin-support-for-java-9-module-system/2499/21?u=darksnake

[altavir]

By the way, you do not need module file for jlink to work, plugin generates it automatically

[altavir]

Though, you are correct, that it is a pain to make it work.

[bjonnh]

if I let it generate it doesn't work at all

[bjonnh]

but the runtime plugin does it

[bjonnh]

I don't even see that checker framework thing anywhere

[bjonnh]

oh that's new in logback

[bjonnh]

…

[bjonnh]

I don't get why it is going in the tests…

[bjonnh]

ok getting there

[bjonnh]

... 1 more
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private javafx.scene.control.TextField net.nprod.fractioncontroller.javafx.AppController.columnsinput accessible: module net.prod.fractioncontroller does not "opens net.nprod.fractioncontroller.javafx" to module javafx.fxml

[altavir]

I will try to check my old build tomorrow. We moved to JS as primary target.

[altavir]

probably going for runtime plugin is a good idea.

[bjonnh]

😄

[bjonnh]

it wanted a : opens net.nprod.fractioncontroller.javafx to javafx.fxml;

[bjonnh]

I'm getting there

[bjonnh]

I think runtime was doing a good job 🙂

[bjonnh]

"java.util.MissingResourceException: Can't find bundle for base name com.sun.javafx.tk.quantum.QuantumMessagesBundle, locale en_US"

[bjonnh]

hah

[bjonnh]

it just never stops

[bjonnh]

looks like a problem coming from jfx 13