Anyone know how to make a Spinner with the editabl...

# tornadofx

[kastork]

Anyone know how to make a Spinner with the editable property set commit for reasons other than hitting "Enter"? Like if the user tabs out of the control

[Ruckus]

https://stackoverflow.com/questions/32340476/manually-typing-in-text-in-javafx-spinner-is-not-updating-the-value-unless-user

[carlw]

Pinning this...seems like the spinner valueProperty comes up every few months

[kastork]

huh, I thought this would be a tornadofx thing

[kastork]

the docs for spinner do say that the Enter key must be pressed

[kastork]

Seems like a design flaw

[kastork]

If this method actually works, I wonder if it could be incorporated into the TornadoFX builder...

[kastork]

spinner.focusedProperty().addListener((observable, oldValue, newValue) -> {
if (!newValue) {
spinner.increment(0); // won't change value, but will commit editor
}
});

[kastork]

hah, seems to work...

[kastork]

@carlw @Ruckus Would it ever make sense for a list-based spinner to be editable?

[kastork]

I ask because I'm wondering if the focus-based behavior should be omitted from fun <T> EventTarget.spinner(items: ObservableList<T>, editable: Boolean = false, property: Property<T>? = null, enableScroll: Boolean = false, op: (Spinner<T>.() -> Unit)? = null): Spinner<T>

[carlw]

you mean because it's a closed set

[kastork]

right

[carlw]

maybe add an 11 on-the-fly to a volume control that's only 1-10?

[kastork]

I guess validation would catch it

[kastork]

same as if you hit Enter

[carlw]

probably a Double is the best use case. there could be a display rounding masking a specific value

[Ruckus]

Maybe if you add some sort of search functionality?

[kastork]

I'm thinking of submitting a PR that adds the focus listener (like Sergio's answer in the SO question)

[kastork]

There are several builder functions for Spinner, and I'm just wondering if the listener is not appropriate for the one that is based on a list

[kastork]

Seems appropriate for all the rest

[Ruckus]

I'm not the one to ask about that. I've only ever bothered to use a spinner a handful of times.

[kastork]

Seems like numbers are hard to use in a textfield.