Since Activities/Fragments can be destroyed and re...
# android-architecturet
tenprint
11/28/2018, 11:02 PMSince Activities/Fragments can be destroyed and recreated using the same ViewModel, does it make sense for us to create scoped Dagger components in our ViewModels? Would there be anything wrong with doing it that way?
g
gildor
11/29/2018, 6:41 AMno, it’s completely valid and imo the best approach, to have own scope for ViewModel
👍 1
t
tenprint
11/29/2018, 2:49 PMThanks @gildor Do you inject in the
init {...}u
ursus
11/29/2018, 5:52 PMwouldnt that make testing ugly if you have globalInjector as the ctor parameter of the viewmodel?
t
tenprint
11/29/2018, 7:02 PMah, actually i’m still trying to understand the best way to handle testing injection. do you have a sample of how you inject your viewmodels?
g
gildor
11/30/2018, 1:14 AMDo you inject in theNo, just use constructor injection + factoriesblock?init {...}
gildor
11/30/2018, 1:15 AMAgree with Vlastimil, using global injection in case of VM is not neccessary, better to use constructor injection, also no problem with testing
u
ursus
11/30/2018, 2:05 AM@gildor btw where do you keep the vm scoped component? it would possible make sens to have on on the vm instance in case of retained vms, like aac. but yet again, ugly, ctor injection would be nicer
t
tenprint
11/30/2018, 3:22 PM@gildor btw where do you keep the vm scoped component?This is my question as well
2 Views