Matthew Pope05/13/2022, 6:09 PM
Ignat Beresnev05/13/2022, 6:13 PM
Matthew Pope05/13/2022, 6:13 PM
Ignat Beresnev05/13/2022, 6:16 PM
mbonnin05/13/2022, 6:20 PM
is added as a dependency to
so you don't have much to do
you should be covered
Matthew Pope05/13/2022, 6:28 PM
in the PR, then the
task is questionably useful because it will always pass because you're always regenerating the baseline API to whatever you are committing. If you do not include the
in the PR, then you don't have a clear way to re-baseline the API checks.
mbonnin05/13/2022, 6:29 PM
that fails on breaking changes but that looks pretty hard to do: https://github.com/Kotlin/binary-compatibility-validator/issues/70
Ignat Beresnev05/13/2022, 6:41 PM
Matthew Pope05/13/2022, 6:43 PM
It will also fail if you accidentally expose something as public API without noticingI don't think it does. I just tested it out by adding a new public function to my library, and
passed even without updating the api dump.
mbonnin05/13/2022, 6:44 PM
Ignat Beresnev05/13/2022, 6:44 PM
Matthew Pope05/13/2022, 6:47 PM
fun foo() = 1
fails on additive changes, then it all makes sense.
altavir05/14/2022, 8:18 PM