tavish pegram
09/07/2020, 5:26 PMparMapN
up to arity 9 but I’m running into some issues
1. ParTupledN
has a huge amount of lag for me in intellij once I kind of scaffolded out the new functions. To the point it’s basically impossible to use intellij to edit that particular file. I haven’t been able to find a solution for that on my own (looks like the the kotlin plugins type checker freaks out when code analysis runs, so anytime anything is edited on the page). I don’t know if its just me, but if it isn’t, is this code new enough that I can split it into multiple files (it’s getting a bit big anyway). I would hope that might help, but its just a guess.
2. Many of the arrow coroutine tests hang indefinitely for me when running the tests locally (though they appear to work in the builds on the PR, such as https://github.com/arrow-kt/arrow-fx/actions/runs/243281626 ) Is this another me problem or is there something weird happening?
3. I’m adding some tests for parMapN for arity 2 and 3 (since it already exists), but it looks like arity 3 was failing one of the tests "parMapN 3 cancels losers if a failure occurs in one of the tasks"
. When messing with the test I found that putting the winner in the third position always caused a hang, so I updated parMapN 3
to use parMapN 2
instead of the existing implementation of parMapN(ctx, fa, fb, fc, f)
and it appears to have fixed it. Is that correct or is there a reason to definitely be using the stand alone implementation of N = 3 instead of composing with N = 2?
Any suggestions appreciated! Thanks!pablisco
09/07/2020, 5:38 PMtavish pegram
09/07/2020, 5:39 PMevalOn
is used in the tests.
so this hangs
checkAll {
single.zip(mapCtx).use { (_single, _mapCtx) ->
evalOn(_single) {
}
}
}
and this does not
checkAll {
single.zip(mapCtx).use { (_single, _mapCtx) ->
}
}
Rachel
09/07/2020, 5:56 PMtavish pegram
09/07/2020, 5:58 PMRachel
09/07/2020, 5:59 PM