Navigation: Why is not the `bottomSheet() {}` navi...

# compose

[Jan Skrasek]

Navigation: Why is not the bottomSheet() {} navigation implemented the same way as the dialog {} one -> i.e. via the Window API?
https://github.com/google/accompanist/tree/main/navigation-material

[Ian Lake]

It is just a wrapper around Compose's ModalBottomSheetLayout, just like how dialog is a wrapper around Compose's Dialog

[Ian Lake]

If the Compose's technique for showing bottom sheets changed, then Navigation would just be a wrapper in whatever that new method was

[Ian Lake]

FWIW, all the bottom sheet APIs are still experimental, so if you want them changed, now would be the time to make your case by filing issues against Compose itself

[Jan Skrasek]

Thanks! Just starting to play with it, no strong opinions yet. I think there is an issue with the overlay over the status bar when the don't draw underneath, this is nicely handled by the own window in dialog.

[Ian Lake]

Nothing in Compose is aware of window insets - you'll want to use Accompanist Insets to control how you interact with those: https://google.github.io/accompanist/insets/

[Jan Skrasek]

https://issuetracker.google.com/issues/251178935