Could we get a new review here? <https://github.co...
# kotest-contributors
s
Could we get a new review here? https://github.com/kotest/kotest-extensions-arrow/pull/189/ The implementation in Kotest changed quite a lot since the original implementation, and I want to make sure the
LifecycleMode
is consistent with the other parts of the Kotest eco-system.
e
Apologies.. I've had that one weighing on my conscience for a while.. 🙈
s
No worries ☺️
e
I'll do a best-effort review tonight.. I recall that I didn't fully understand all aspects of it, so take it for what it's worth. 😄
s
The implementation has been simplified quite a lot, since all the internals have moved to Arrow by now. So you can decompose a
Resource<A>
into
A
and a finaliser
() -> A
, then it needs to be hooked up into Kotest correctly and respect the
LifecycleMode
. If you have doubts about anything just leave a comment, and I'll try to clear it up. Any review, and help is very appreciated 🙏
e
Reviewed. I think it looks good. Just added some minor questions and comments