I am having a weird issue when running ktlint locally (using the gradle plugin) where check and form...

# ktlint

[dazza5000]

I am having a weird issue when running ktlint locally (using the gradle plugin) where check and format do not line up

daz@daz:/source/source/well/consumer-android-ui-2$ git status
On branch MOB-310-integrate-ktlint
Your branch is up to date with 'origin/MOB-310-integrate-ktlint'.

nothing to commit, working tree clean
daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetCheck
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 919ms
16 actionable tasks: 1 executed, 15 up-to-date
(failed reverse-i-search)`forma': git reset --hard origin/MOB-1190-calculate-height-^Cr-list-items
daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetFormat
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 1s
16 actionable tasks: 2 executed, 14 up-to-date
daz@daz:/source/source/well/consumer-android-ui-2$ git status
On branch MOB-310-integrate-ktlint
Your branch is up to date with 'origin/MOB-310-integrate-ktlint'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   app/src/debug/java/co/foo/data/session/LocalSessionDataSource.kt
        modified:   app/src/debug/java/co/foo/util/FlipperUtil.kt

no changes added to commit (use "git add" and/or "git commit -a")

[jlleitschuh]

Which Gradle Plugin?

[jlleitschuh]

I believe there are two

[jlleitschuh]

Three if you include spotless

[dazza5000]

the one you write big dog

[dazza5000]

this is my config

ktlint {
    version.set("0.45.2")
    android.set(true)
    reporters {
        reporter(ReporterType.HTML)
    }
    outputColorName.set("RED")
    disabledRules.set(setOf("no-wildcard-imports"))
}

[jlleitschuh]

That's probably mine then

[dazza5000]

id("org.jlleitschuh.gradle.ktlint") version Versions.ktlint

[dazza5000]

const val ktlint = "10.2.1"

[jlleitschuh]

So, running 'format' doesn't update the sources?

[dazza5000]

format does

[dazza5000]

but check is not failing

[dazza5000]

daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetCheck
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 919ms

[dazza5000]

daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetFormat
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 1s
16 actionable tasks: 2 executed, 14 up-to-date
daz@daz:/source/source/well/consumer-android-ui-2$ git status
On branch MOB-310-integrate-ktlint
Your branch is up to date with 'origin/MOB-310-integrate-ktlint'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   app/src/debug/java/co/foo/data/session/LocalSessionDataSource.kt
        modified:   app/src/debug/java/co/foo/util/FlipperUtil.kt

[dazza5000]

and it's weird because :app:ktlintDebugSourceSetCheck is failing in CI

[dazza5000]

but not locally...

[dazza5000]

maybe it is an IDE config or something

[Sha Sha Chu]

when it fails on CI, what rule(s) are failling?

[jlleitschuh]

I don't know what the 'debug' variant of the task does, I'm not familiar with it

[jlleitschuh]

Consider only running the high-level tasks, format and check, not the ones on specific source sets

[jlleitschuh]

The ones on specific source sets aren't meant to be run in isolation IIRC

[dazza5000]

> Task :app:ktlintDebugSourceSetCheck FAILED
/bitrise/src/app/src/debug/java/co/[REDACTED]/[REDACTED]app/data/session/LocalSessionDataSource.kt:1:1 File must end with a newline (\n)
/bitrise/src/app/src/debug/java/co/[REDACTED]/[REDACTED]app/util/FlipperUtil.kt:1:1 File must end with a newline (\n)
/bitrise/src/app/src/debug/java/co/[REDACTED]/[REDACTED]app/util/FlipperUtil.kt:29:19 Missing newline after ","

[jlleitschuh]

What happens when you run the format task?

[dazza5000]

it formats the files

[dazza5000]

just like what I put here

[dazza5000]

modified:   app/src/debug/java/co/foo/data/session/LocalSessionDataSource.kt
        modified:   app/src/debug/java/co/foo/util/FlipperUtil.kt

[dazza5000]

didn't realize we weren't supposed to run the tasks independently

[jlleitschuh]

So, I don't understand the problem, does format fix the problem? Or no?

[jlleitschuh]

Opening an issue may help, I'm not understanding the full issue. There's unfortunately not enough context here

[dazza5000]

the problem is format fixes the problem, but check does not find the problems that format fixes

[jlleitschuh]

Oh

[dazza5000]

CHECK = no find problem FORMAT = formats problem

[jlleitschuh]

Hrm...

[dazza5000]

im new to all of this, i could be breaking something

[dazza5000]

thanks for the hints

[jlleitschuh]

There's a bug in this area, it has to do with caching, having your inputs be the same as your outputs cause problems for Gradle. There's only so much we can do in this area unfortunately

[dazza5000]

the inputs/outputs being files?

[jlleitschuh]

Yea, the source code files

[dazza5000]

who makes this gradle trash?

[dazza5000]

jkjkjk 😉

[dazza5000]

rather have some gradle than ant, maven, etc

[jlleitschuh]

I used to 🙂

[dazza5000]

i know, that is why i was teasing you

[dazza5000]

😛