Unfortunately, I have another change request: it’s...

# orbit-mvi

[Oleksii Malovanyi]

Unfortunately, I have another change request: it’s about runOnCreate in tests -> it blocks, so if you have a delay or withTimeout call right when the container is created, your test would still be live timed 😞
https://github.com/orbit-mvi/orbit-mvi/pull/53

[Oleksii Malovanyi]

the only thing to notice, is that it’s required test() to be a suspending function –> that’s breaking, but I guess as testIntent is suspending too, anyway, it doesn’t matter much ¯\_(ツ)_/¯

[Mikolaj Leszczynski]

Food for thought -

I think runOnCreate might be a bit hidden inside the test function anyway.

How about moving it out into its own separate (suspending in suspending test mode, blocking in live test mode) function in TestContainerHost instead?

[Mikolaj Leszczynski]

The onCreate lambda is not suspending, I suppose the only reason for it to be suspending is so it can run any fired off intents so it’s a bit of a weird one

[Oleksii Malovanyi]

@Mikolaj Leszczynski I like the idea to test runOnCreate with it’s own function, so it could look like

createViewModel()
            .testOnCreate() // <-- ¯\_(ツ)_/¯ 
            .testIntent { onFilterClick() }
            .assert(initialState) {
                postedSideEffects(OffersEffect.NavigateToFilters)
            }

[Mikolaj Leszczynski]

Makes sense to me, let's make it happen 🙂

[Mikolaj Leszczynski]

Although I think you're missing a test

[Mikolaj Leszczynski]

At the beginning

[Oleksii Malovanyi]

yeah, sorry, it’s just our internal code style -> we hide test() call under the createViewModel() func

[Oleksii Malovanyi]

btw, testOnCreate or runOnCreate 🤔

[Mikolaj Leszczynski]

Test I guess

[Mikolaj Leszczynski]

Although not so sure now 😜

[Oleksii Malovanyi]

because, u know, this func would not test anything, just invoke

[Oleksii Malovanyi]

okay, let me try

[Oleksii Malovanyi]

@Mikolaj Leszczynski I’ve updated the PR -> it’s ready for review

[Mikolaj Leszczynski]

Cool, thanks. Will take a look when I have some spare time

[Mikolaj Leszczynski]

@Oleksii Malovanyi done

[Oleksii Malovanyi]

thanks! I’d better revert changes from the 1st commit first 😞 I’d update PR tmrw – I guess all comments are totally valid 👌

[Oleksii Malovanyi]

@Mikolaj Leszczynski PR is ready for another round of review 😉

[Mikolaj Leszczynski]

@Oleksii Malovanyi 👍 from me, I asked @appmattus to take another look

[appmattus]

Approved and auto merge enabled

[Oleksii Malovanyi]

thanks for the quick feedback 🎉

[Oleksii Malovanyi]

any possible release date?

[Mikolaj Leszczynski]

Yesterday 😂

[Mikolaj Leszczynski]

4.1.0 but we haven't announced yet

[Oleksii Malovanyi]

😲 omg

[Oleksii Malovanyi]

fyi: I’ve integrated the changes -> seems to be working flawlessly