I have another proposal on testing :grimacing:
<ht...
# orbit-mvio
Oleksii Malovanyi
07/02/2021, 10:01 AMI have another proposal on testing 😬
https://github.com/orbit-mvi/orbit-mvi/pull/52
👍 2
m
Mikolaj Leszczynski
07/02/2021, 10:46 AMGood point, we missed this case
Mikolaj Leszczynski
07/02/2021, 10:47 AMI mean arguably you could move the
ifintentMikolaj Leszczynski
07/02/2021, 10:48 AMbut I don’t see why we shouldn’t allow both - we shouldn’t throw an exception perhaps
Mikolaj Leszczynski
07/02/2021, 10:49 AMif the saved intents is empty we should just do nothing
o
Oleksii Malovanyi
07/02/2021, 10:49 AMI like the default behaviour – just to remind the user why he is invoking this testIntent method
Oleksii Malovanyi
07/02/2021, 10:50 AMI just wanna have an ability to override the default behaviour cause clearly there is a case when you dont always would call the intent underneath
m
Mikolaj Leszczynski
07/02/2021, 10:50 AMtrue, but adding a switch for this complicates the API layer
Mikolaj Leszczynski
07/02/2021, 10:50 AMit’s not immediately intuitive
o
Oleksii Malovanyi
07/02/2021, 10:51 AMagree 🤔
m
Mikolaj Leszczynski
07/02/2021, 10:51 AMon balance, I think we shouldn’t throw an exception
Mikolaj Leszczynski
07/02/2021, 10:51 AManother great find 🙂
o
Oleksii Malovanyi
07/02/2021, 10:52 AMokay, I’ll update my changes then shortly
🙇♂️ 1
7 Views