https://kotlinlang.org logo
#orbit-mvi
Title
# orbit-mvi
o

Oleksii Malovanyi

07/02/2021, 10:01 AM
I have another proposal on testing 😬 https://github.com/orbit-mvi/orbit-mvi/pull/52
👍 2
m

Mikolaj Leszczynski

07/02/2021, 10:46 AM
Good point, we missed this case
I mean arguably you could move the
if
inside the
intent
but I don’t see why we shouldn’t allow both - we shouldn’t throw an exception perhaps
if the saved intents is empty we should just do nothing
o

Oleksii Malovanyi

07/02/2021, 10:49 AM
I like the default behaviour – just to remind the user why he is invoking this testIntent method
I just wanna have an ability to override the default behaviour cause clearly there is a case when you dont always would call the intent underneath
m

Mikolaj Leszczynski

07/02/2021, 10:50 AM
true, but adding a switch for this complicates the API layer
it’s not immediately intuitive
o

Oleksii Malovanyi

07/02/2021, 10:51 AM
agree 🤔
m

Mikolaj Leszczynski

07/02/2021, 10:51 AM
on balance, I think we shouldn’t throw an exception
another great find 🙂
o

Oleksii Malovanyi

07/02/2021, 10:52 AM
okay, I’ll update my changes then shortly
🙇‍♂️ 1
7 Views