https://kotlinlang.org logo
#kotest-contributors
Title
# kotest-contributors
a

AJ Alt

05/02/2022, 3:47 PM
fyi it seems like the search addition causes the the top bar to degrade somewhat poorly on smaller screens like my laptop:
s

sam

05/02/2022, 3:55 PM
might be worth us make the links be more terse
e

Emil Kantis

05/02/2022, 11:00 PM
perhaps the issue tracker link could be scrapped? Or Github link could use a octocat icon
s

sam

05/02/2022, 11:00 PM
Yep either or both
e

Emil Kantis

05/02/2022, 11:15 PM
pushed the icon change, @AJ Alt can you check if it looks decent now?
a

AJ Alt

05/03/2022, 12:17 PM
definitely better, but there is still some overlapping
e

Emil Kantis

05/03/2022, 12:27 PM
Okay.. I think we should remove the issue tracker link then.. Could be found using the GH link 🤷 @sam ok with you?
s

sam

05/03/2022, 1:00 PM
Fine by me. No more bugs 🙂
e

Emil Kantis

05/03/2022, 1:01 PM
😁
aaand it's gone 💨
s

sam

05/03/2022, 2:26 PM
beautiful
Did you do the 5.3 docs ?
or did it magically happen
e

Emil Kantis

05/03/2022, 2:33 PM
I fixed it
s

sam

05/03/2022, 2:33 PM
nice 🙂
a

AJ Alt

05/03/2022, 3:06 PM
Nice! The search bar doesn't overlap the buttons any more, although their text still draws over the edge of the top bar. Not a big deal.
s

sam

05/03/2022, 3:09 PM
Could prob rename property testing to prop testing, and intellij plugin to just intellij
a

AJ Alt

05/03/2022, 3:10 PM
On phones, the search bar collapses to a button. Maybe you could increase the minimum window width where that happens?
e

Emil Kantis

05/03/2022, 3:10 PM
There's a media query for that. I think the breakpoint was ~1000 px
maybe? 🙂
s

sam

05/03/2022, 6:05 PM
Personally I'd say no. Framework/Assertions/Proptest have always been the three areas that you can pick from.
👍 1
The intellij plugin I'd be ok moving inside framework though
2 Views