Could you have a look at this when you have some m...
# kotest-contributorse
Emil Kantis
09/22/2021, 2:04 PMCould you have a look at this when you have some minutes to spare @sam? 🙂 https://github.com/kotest/kotest/pull/2532
I also started looking into the shrinker-thing, but nothing to share yet 🙂
s
sam
09/22/2021, 2:05 PMWhat's the tl'dr of what you changed/fixed
e
Emil Kantis
09/22/2021, 2:12 PMSupport for reflective bind of more types. Data classes containing other data classes, lists, sets, some java.time types
Emil Kantis
09/22/2021, 2:12 PMBonus:
Arb.pairEmil Kantis
09/22/2021, 2:14 PMAnd I'm mostly wondering if I'm missing something major or if it looks good to merge. Added some tests for what I felt was relevant but I might have some blind spots I suppose, don't know the surrounding code very well
s
sam
09/22/2021, 2:14 PMIt looks good, the ability for recursive members of data classes is cool.
sam
09/22/2021, 2:15 PMI should write some more docs on the amazing prop test support
e
Emil Kantis
09/22/2021, 2:37 PMI'll update the inline doc for Bind at least to reflect that it now supports some more stuff.. 🙂
Emil Kantis
09/22/2021, 2:37 PMand the random thing
s
sam
09/22/2021, 2:37 PMright
2 Views