https://kotlinlang.org logo
#kotest-contributors
Title
# kotest-contributors
r

reevn

07/22/2020, 6:39 PM
Hey 👋 I'm in the process of adding some new listener callbacks (https://github.com/kotest/kotest/issues/1584). I've looked how
beforeTest
is implemented and followed the same pattern. I've found the
TestLifecycleAware
interface from a 3rd party library which contains
beforeTest
and
afterTest
that is overridden and executed by our
TestLifecycleAwareListener
. Does this also need to somehow be updated, or is that just the one mapping we need to this library and other similar callbacks we add do not need to be mapped to
TestlifecycleAware
?
s

sam

07/22/2020, 6:42 PM
This is where the implementation details of these callbacks gets tricky and why its not quite as simple as it appears when we were chatting on github
For example the TestLifecycleAware is for TestContainers
When would you want to start the container? You need to somehow map these new callbacks to the same semantics in that projects listener interface.
r

reevn

07/22/2020, 6:48 PM
I need to read up a bit on TestContainers to make more sense of it. I think besides this and mapping the new callbacks to the extensions that are available, the implementation seems to be working from writing test cases for it. I will come back after I've read up on TestContainers a bit and how it used in Kotest 🙂
Btw the codebase in general seems to be written in a very readable fashion and I had no problem diving straight into it. Very nice 🎉
👍🏻 1
s

sam

07/22/2020, 7:16 PM
Ok that sounds great
I'm looking forward to seeing it
r

reevn

07/22/2020, 9:20 PM
I think I've understood all the extensions and think the feature is done. I've opened a draft PR and will leave it in that state until you gathered feedback about deprecating
beforeTest
/
afterTest
. Looking forward to feedback 🙂
4 Views